Reject empty source public keys file in consolidate command - #801
Open
cyc60 wants to merge 3 commits into
Open
Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An empty
--source-public-keys-filepassed CLI validation (validate_public_keys_fileiterates lines, so a zero-line file is accepted) and loaded as an empty list. Sinceprocess()buildsConsolidationKeysonly whensource_public_keysis truthy, the command silently fell through to the auto-pick (ConsolidationSelector) path — ignoring the user's explicit--target-public-keyand consolidating validators the user never chose, with no warning.The consolidate command now raises a clean error when the provided source keys file yields no keys. Files with blank lines were already rejected upfront by the CLI callback, so the check targets the zero-keys case specifically.
validate_public_keys_fileis left unchanged, as it is shared with--exclude-public-keys-file, where an empty file is harmless.Adds the first tests for the consolidate command (
src/validators/commands/tests/test_consolidate.py).