Cleanup empty tests, add --cores argument#470
Merged
mitzimorris merged 4 commits intodevelopfrom Oct 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #470 +/- ##
===========================================
- Coverage 77.87% 77.48% -0.39%
===========================================
Files 30 20 -10
Lines 9174 6112 -3062
===========================================
- Hits 7144 4736 -2408
+ Misses 2030 1376 -654
Continue to review full report at Codecov.
|
mitzimorris
approved these changes
Oct 8, 2021
Member
mitzimorris
left a comment
There was a problem hiding this comment.
LGTM! cores arg is much needed, ditto cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
This does some mypy cleanup following #461. It also closes #467 and closes #466
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: