Feature/issue 197 remove writer

[syclik]

Summary:

This updates stan_fit.hpp to work with the latest develop branch of Stan.

Intended Effect:

With stan-dev/stan#1601, some of the header files were removed. These were moved to RStan.

How to Verify:

This should compile and work exactly like the version without it.

Side Effects:

@bgoodri, can you double check the changes to stan_fit.hpp? It looks like the merge brought back in the section for advi... If you want that removed, just say so and I'll remove the sections.

Documentation:

None required.

Reviewer Suggestions:

@bgoodri

[syclik]

@bgoodri, just FYI, the failure was a travis-ci thing. It timed out trying to get R.

This is to get RStan up to develop. I'd wait on merging until after 2.8.0-1 or whatever you're working on for release now.

[ariddell]

Is there some way to track these refactoring tasks centrally? Should there be a meta-task in the stan repo? It also occurred to me that having a stan-3-stage-1 milestone or something like that would be useful.

[syclik]

There is a meta-task in the repo. This fix is post 2.8.0, but not Stan 3.
Once you release 2.8.0, I have a pull request ready to go.

(When releasing 2.8.0, if you use the v2.8.0 tagged version of the Stan
library, you won't need this patch.)

On Sat, Sep 26, 2015 at 10:03 AM, Allen Riddell notifications@github.com
wrote:

Is there some way to track these refactoring tasks centrally? Should there
be a meta-task in the stan repo? It also occurred to me that having a
stan-3-stage-1 milestone or something like that would be useful.

—
Reply to this email directly or view it on GitHub
#213 (comment).

[ariddell]

PyStan 2.8.0.0 is out. Just waiting for the uploads of these monster OS
X wheels to make the announcement.

On 09/26, Daniel Lee wrote:

There is a meta-task in the repo. This fix is post 2.8.0, but not Stan 3.
Once you release 2.8.0, I have a pull request ready to go.

(When releasing 2.8.0, if you use the v2.8.0 tagged version of the Stan
library, you won't need this patch.)

On Sat, Sep 26, 2015 at 10:03 AM, Allen Riddell notifications@github.com
wrote:

Is there some way to track these refactoring tasks centrally? Should there
be a meta-task in the stan repo? It also occurred to me that having a
stan-3-stage-1 milestone or something like that would be useful.

—
Reply to this email directly or view it on GitHub
#213 (comment).

---

Reply to this email directly or view it on GitHub:
#213 (comment)

[bgoodri]

Okay to merge this? Anything else needed for 2.9?

[maverickg]

Some error messages cannot find their ways to the output; some units tests failed here: https://travis-ci.org/stan-dev/rstan/jobs/94535542

[maverickg]

I think I fixed the error message issue in the unit tests in develop branch.

[syclik]

Hi Jiqiang, does that one fix actually work? I tried the same thing and it
didn't pass. If so, then great! (and sorry for not getting it right the
first time.)

On Thu, Dec 3, 2015 at 2:26 PM, maverickg notifications@github.com wrote:

I think I fixed the error message issue in the unit tests in develop
branch.

—
Reply to this email directly or view it on GitHub
#213 (comment).

[maverickg]

@syclik It works.