add BH, RcppEigen to pkgdown workflow file instead of Suggests#158
Merged
Conversation
Member
Author
|
pkgdown workflow is passing https://github.com/stan-dev/rstantools/actions/runs/29931490602. This PR shouldn't affect anything else but I guess I'll let the rest of the checks finish before merging |
Member
|
Main site builds on releases, not just tags I think. So just need to do that when a new version goes out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andrjohns let's merge this before the CRAN release. I had put these packages in Suggests to get the vignette to build but they should just go in the workflow file since rstantools doesn't directly call them
Also thanks to work from @VisruthSK the website shouldn't need to be manually updated, it should update automatically when you tag the GitHub release (or maybe even just when changing the version number on the master branch)