Skip to content

Feature/make stan functions#2741

Closed
bgoodri wants to merge 2 commits into
developfrom
feature/make_stan-functions
Closed

Feature/make stan functions#2741
bgoodri wants to merge 2 commits into
developfrom
feature/make_stan-functions

Conversation

@bgoodri
Copy link
Copy Markdown
Contributor

@bgoodri bgoodri commented Mar 16, 2019

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit Does not touch C++ code
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Adds a make target to create the stan-functions.txt file that we had before the switch to RMarkdown-based documentation

Intended Effect

Fixes #2740

How to Verify

make manual

Side Effects

None

Documentation

None

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Trustees of Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter
Copy link
Copy Markdown
Member

I can approve this when the conflicts are resolved.

I thought an alternative was created to the earlier code, which is why I deleted it in an earlier PR.

@bgoodri
Copy link
Copy Markdown
Contributor Author

bgoodri commented Apr 7, 2019

Does this have to be moved into the docs repo now?

@bob-carpenter
Copy link
Copy Markdown
Member

I'm not sure what the plan is. Hopefully @mitzimorris or @seantalts will know.

@mitzimorris
Copy link
Copy Markdown
Member

all functions signatures were converted into HTML comments in the .Rmd files.
in the docs repo, this command will get you the function sigs:
grep '^<!--' src/functions-reference/*.Rmd

there are 666 of them.

@bgoodri
Copy link
Copy Markdown
Contributor Author

bgoodri commented Apr 11, 2019 via email

@mitzimorris
Copy link
Copy Markdown
Member

OK - looks like conversion didn't get all sigs for the built-in functions but did for the distributions.
will fix.

@mitzimorris
Copy link
Copy Markdown
Member

stan-dev/docs#42

@serban-nicusor-toptal serban-nicusor-toptal added this to the 2.20.0 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stan-functions.txt is not created anymore

4 participants