Feature/make stan functions#2741
Closed
bgoodri wants to merge 2 commits into
Closed
Conversation
Member
|
I can approve this when the conflicts are resolved. I thought an alternative was created to the earlier code, which is why I deleted it in an earlier PR. |
Contributor
Author
|
Does this have to be moved into the docs repo now? |
Member
|
I'm not sure what the plan is. Hopefully @mitzimorris or @seantalts will know. |
Member
|
all functions signatures were converted into HTML comments in the .Rmd files. there are 666 of them. |
Contributor
Author
|
But we had 711 signatures in 2.18.x
…On Wed, Apr 10, 2019 at 10:38 PM Mitzi Morris ***@***.***> wrote:
Closed #2741 <#2741>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2741 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADOrqrikkJVj9H7gGbILn9_9zYVS4hMpks5vfqAQgaJpZM4b3qdP>
.
|
Member
|
OK - looks like conversion didn't get all sigs for the built-in functions but did for the distributions. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unitDoes not touch C++ codemake cpplintSummary
Adds a
maketarget to create the stan-functions.txt file that we had before the switch to RMarkdown-based documentationIntended Effect
Fixes #2740
How to Verify
Side Effects
None
Documentation
None
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Trustees of Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: