Skip to content

Remove template from tranform inits call#3026

Merged
rok-cesnovar merged 4 commits intodevelopfrom
fix_model_base_crtp
Mar 19, 2021
Merged

Remove template from tranform inits call#3026
rok-cesnovar merged 4 commits intodevelopfrom
fix_model_base_crtp

Conversation

@rok-cesnovar
Copy link
Copy Markdown
Member

Summary

Fix for recent clang versions (example reported in https://discourse.mc-stan.org/t/failing-to-make-example-bernoulli-bernoulli-on-cmdstan-fresh-installation/21370).

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar requested a review from bbbales2 March 19, 2021 11:35
@rok-cesnovar rok-cesnovar changed the title Remove tranform inits from model_base_crtp Remove template from tranform inits call Mar 19, 2021
Copy link
Copy Markdown
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@stan-buildbot
Copy link
Copy Markdown
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.39 3.55 0.96 -4.55% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.94 -5.87% slower
eight_schools/eight_schools.stan 0.11 0.11 0.99 -1.38% slower
gp_regr/gp_regr.stan 0.17 0.16 1.07 6.2% faster
irt_2pl/irt_2pl.stan 5.32 5.23 1.02 1.67% faster
performance.compilation 89.95 88.52 1.02 1.59% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.88 8.97 0.99 -0.99% slower
pkpd/one_comp_mm_elim_abs.stan 30.92 31.31 0.99 -1.24% slower
sir/sir.stan 128.52 133.11 0.97 -3.57% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.02 2.34% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.07 3.12 0.98 -1.6% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.37 0.38 0.99 -1.44% slower
arK/arK.stan 1.92 1.91 1.0 0.19% faster
arma/arma.stan 0.64 0.63 1.01 0.92% faster
garch/garch.stan 0.51 0.51 0.99 -0.7% slower
Mean result: 0.995224567368

Jenkins Console Log
Blue Ocean
Commit hash: b1fd1e8


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar merged commit 792e9c2 into develop Mar 19, 2021
@rok-cesnovar rok-cesnovar deleted the fix_model_base_crtp branch March 19, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants