Skip to content

Fix Optimize.ml to not depend on Base - #1672

Merged
WardBrian merged 3 commits into
stan-dev:masterfrom
nhuurre:fix/vectorize-loops-nobase
Aug 21, 2026
Merged

Fix Optimize.ml to not depend on Base#1672
WardBrian merged 3 commits into
stan-dev:masterfrom
nhuurre:fix/vectorize-loops-nobase

Conversation

@nhuurre

@nhuurre nhuurre commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:
    • OR, no user-facing changes were made

#1666 branched off before #1663 so it was still depending on Base, and consequently broke builds (#1670)

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (66f569f) to head (56a75a1).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1672   +/-   ##
=======================================
  Coverage   92.26%   92.27%           
=======================================
  Files          69       69           
  Lines       10136    10198   +62     
=======================================
+ Hits         9352     9410   +58     
- Misses        784      788    +4     
Files with missing lines Coverage Δ
src/analysis_and_optimization/Optimize.ml 93.51% <100.00%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WardBrian

Copy link
Copy Markdown
Member

Thanks, I wasn’t sure how many places would need an update, so reverting to unblock before the weekend seemed easiest…

Would you also mind deleting more or less all the code comments from #1666? They all give me the slop-ick feeling, especially comments that list where a helper function is called or say things like “Whole-variable assignments are size-checked”

@nhuurre

nhuurre commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Darn it, the only reason those comments made it through review was that I didn't want to read "slop-ick."

@WardBrian

Copy link
Copy Markdown
Member

Definitely, I feel like I almost cant read them; my brain refuses to actually take them seriously enough to even digest what they’re trying to say. This article from the front page of HN today described the phenomenon well. https://cymerys.com/w/im-becoming-ai-blind

@WardBrian
WardBrian merged commit 90c6532 into stan-dev:master Aug 21, 2026
3 checks passed
@nhuurre
nhuurre deleted the fix/vectorize-loops-nobase branch August 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants