Fix Optimize.ml to not depend on Base - #1672
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1672 +/- ##
=======================================
Coverage 92.26% 92.27%
=======================================
Files 69 69
Lines 10136 10198 +62
=======================================
+ Hits 9352 9410 +58
- Misses 784 788 +4
🚀 New features to boost your workflow:
|
|
Thanks, I wasn’t sure how many places would need an update, so reverting to unblock before the weekend seemed easiest… Would you also mind deleting more or less all the code comments from #1666? They all give me the slop-ick feeling, especially comments that list where a helper function is called or say things like “Whole-variable assignments are size-checked” |
|
Darn it, the only reason those comments made it through review was that I didn't want to read "slop-ick." |
|
Definitely, I feel like I almost cant read them; my brain refuses to actually take them seriously enough to even digest what they’re trying to say. This article from the front page of HN today described the phenomenon well. https://cymerys.com/w/im-becoming-ai-blind |
Submission Checklist
#1666 branched off before #1663 so it was still depending on Base, and consequently broke builds (#1670)
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)