Skip to content

(fix) GCC array bounds checking complaint #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CarlosNihelton wants to merge 2 commits into from
Closed

(fix) GCC array bounds checking complaint #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ce5189
(fix) GCC array bounds checking complaint
CarlosNihelton Feb 5, 2023
79bed01
Assertion instead of exception
CarlosNihelton Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libclang/libclang_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,16 @@ bool is_absolute(const std::string& file)

std::string get_full_path(const detail::cxstring& dir, const std::string& file)
{
DEBUG_ASSERT(!dir.empty(), detail::precondition_error_handler{},
"Either file is absolute or relative to some named dir");
if (is_absolute(file))
// absolute file
return file;
else if (dir[dir.length() - 1] != '/' && dir[dir.length() - 1] != '\\')
// GCC fails to understand that the assertion would avoid reaching this line if dir was empty.
#if defined __GNUC__
# pragma GCC diagnostic ignored "-Warray-bounds"
#endif
if (dir[dir.length() - 1] != '/' && dir[dir.length() - 1] != '\\')
// relative needing separator
return dir.std_str() + '/' + file;
else
Expand Down