[audit] fix LspToggle compat guard: nvim-0.12 → nvim-0.11#276
Merged
Conversation
client:stop() (colon-notation) landed in 0.11 as part of the client method capitalisation wave; vim.lsp.stop_client() was deprecated in 0.12. The version check was one release too late, meaning the deprecated fallback was called unnecessarily on 0.11. Closes #263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
client:stop()(colon-notation) has been available since Neovim 0.11, as part of the broad client-method capitalisation sweep in that release. The version gate inLspTogglewas checking fornvim-0.12, which meantvim.lsp.stop_client()(deprecated in 0.12) was called unnecessarily on any 0.11.x build.Where
lua/config/plugin_config.lualine 136Why it matters
vim.lsp.stop_client()still works but is the legacy path;client:stop()is the correct modern call.vim.lsp.stop_client()is deprecated (confirmed indeprecated.txtfor v0.12.0).References
Closes #263
Generated by Claude Code