Skip to content

Fix pyproject.toml to include package data #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Fix pyproject.toml to include package data #7869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
934beea
fix pyproject.toml
TomeHirata Feb 27, 2025
8f4280c
revert unused changes
TomeHirata Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,12 @@ dependencies = [
]

[tool.setuptools.packages.find]
include = ["dspy*"]
where = ["."]
include = ["dspy", "dspy.*"]
exclude = ["tests", "tests.*"]
Copy link
Collaborator

@chenmoneygithub chenmoneygithub Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious - since we do explicit include, do we still need this exclude part?

Non-blocking, feel free to merge!

Copy link
Collaborator Author

@TomeHirata TomeHirata Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not necessary (I confirmed "tests" are not included when removing this line), but mostly for the safeguard. We do the same configuration in mlflow: https://github.com/mlflow/mlflow/blob/master/pyproject.release.toml#L139


[tool.setuptools]
include-package-data = true
[tool.setuptools.package-data]
dspy = ["primitives/*.js"]

[project.optional-dependencies]
anthropic = ["anthropic>=0.18.0,<1.0.0"]
Expand Down
Loading