This repository was archived by the owner on Dec 4, 2025. It is now read-only.
Feat/16kb page size compliance - #7
Merged
Merged
Conversation
- Resolved merge conflict in task-013 markdown file - Preserved completed status and implementation notes from upstream - Maintained quick record feature documentation and bug fixes
…plication - Remove entire iosApp/ directory and all iOS-specific build artifacts - Clean up shared/build.gradle.kts: remove iOS targets, source sets, and cinterop configurations - Clean up core/audio/build.gradle.kts: remove iOS targets and framework configurations - Remove iOS source directories: shared/src/iosMain/, core/audio/src/iosMain/, shared/src/iosTest/ - Remove nativeInterop directory containing iOS-specific cinterop definitions - Verify all expect/actual declarations maintain Android implementations - Confirm Android build functionality remains intact This transformation aligns with the project's focus on Android development while maintaining clean architecture and the ability to sync with upstream changes for Android and common modules. Implements: task-053
- Update .gitattributes to remove obsolete iOS merge rules - Update README.md to reflect Android-only focus and remove iOS references - Update CLAUDE.md to remove iOS build commands and development sections - Update Makefile platform description to Android-only - Simplify onboarding code by removing iOS platform conditionals - Remove unused iOS onboarding images from drawable resources This completes the iOS decommissioning work started in the previous commit, ensuring all documentation and code properly reflects the Android-only transition while maintaining upstream sync compatibility. Related: task-053
- Fix platform context handling to enable proper tablet/landscape detection - Add context-aware getPlatform() overload with proper DI integration - Simplify UI components by removing unnecessary iOS platform conditionals - Update documentation to reflect Android-focused approach - Ensure BuildConfig.VERSION_NAME is used consistently Resolves platform detection issues identified in PR review while maintaining clean architecture and backward compatibility.
- Move constants in NoteListViewModel to companion object for better encapsulation - Replace hard-coded resource selection in ModelSetupPage with sealed class pattern - Add comprehensive unit tests for OnboardingViewModel covering state transitions - Add comprehensive unit tests for PlatformViewModel covering platform operations - Remove iOS references from GitHub workflow files These changes address minor code quality suggestions from the automated PR review while maintaining existing functionality and architectural patterns.
- Update NDK r27 configuration for flexible page size support - Add 16KB page size linker flags to CMake builds - Configure uncompressed native libraries in APK packaging - Add comprehensive 16KB testing documentation to CLAUDE.md Ensures compliance with Google Play Store requirement starting November 1st, 2025 for apps targeting Android 15+ devices while maintaining backward compatibility. Files modified: - gradle.properties: Added NDK r27 flexible page size flags - shared/build.gradle.kts: Configured uncompressed native libs - lib/src/main/jni/whisper/CMakeLists.txt: Added 16KB linker flags - CLAUDE.md: Added testing and compliance documentation Verified with successful debug and release builds.
Keep configuration clean by removing explanatory comments about 16KB page size support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.