refactor: extract shared dry-run, config-persist, and command helpers (v0.4.4)#18
Merged
Conversation
…em output behind --verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplication pass, extracts four shared helpers for four copied patterns across modules, plus two small output fixes
Changes
Refactors
utils::report_summaryreplaces the copiedif dry_run { if verbose { "Would X" } } else { "X" }block inmono/config.rs(×2) andmono/watch.rs.mono::npm::read_package_jsonshared reader for{repo}/package.json(verbose warnings on unreadable/malformed files), replacingduplicated logic in
create_mono_repo_package_jsonandget_watch_command.run_timedcollapses the six identicalcrate::time! { ctx.runner.run(...) }wrappers across cmake/meson/npm builds.config::persist_or_dry_runpins the no mutate/save on dry-run blockin one place for
add_config,remove_config,add_profile,remove_profile.Fixes
generate_watch_scriptsresolved each lib's watch command twice, reading/parsing everypackage.jsontwice and printing every verbose warning twice. Commands are now resolved once.test_clone_repos_per_repo_lines_always_shownaccordingly.Tests
report_summary(full dry-run + verbose) andread_package_json(missing-file and malformed-JSON branches + verbose).