Skip to content

apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash#13949

Open
sirandreww-starkware wants to merge 1 commit into05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gatewayfrom
05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash
Open

apollo_consensus_orchestrator: include fee_proposal_fri in proposal commitment hash#13949
sirandreww-starkware wants to merge 1 commit into05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gatewayfrom
05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this May 3, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from 1550bb9 to 938efa4 Compare May 3, 2026 13:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch 2 times, most recently from 5492f1a to 99f41f5 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from 938efa4 to 61da281 Compare May 3, 2026 14:34
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review May 4, 2026 06:07
@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

High Risk
Changes the consensus-signed ProposalCommitment derivation to include fee_proposal_fri, so mismatches will cause proposal validation/decision mismatches across nodes and versions if rolled out inconsistently.

Overview
Proposal commitments now commit to SNIP-35 fee proposals. A new snip35::proposal_commitment_from computes ProposalCommitment as either the legacy partial_block_hash (pre-v0.14.3 / fee_proposal_fri == None) or Poseidon(partial_block_hash, fee_proposal_fri).

The orchestrator now uses this commitment derivation in both proposer and validator paths (build_proposal, validate_proposal, and BuiltProposals::insert_proposal), and updates parent-commitment plumbing accordingly (currently passing None for parent fee proposal).

Tests and test helpers were updated to set a default fee_proposal_fri and to assert commitments via proposal_commitment_from, ensuring proposer/validator expectations match the new hash binding.

Reviewed by Cursor Bugbot for commit 6ecebd0. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from 61da281 to b64fa48 Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 99f41f5 to a2dc0e3 Compare May 4, 2026 07:11
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from b64fa48 to 4ddafee Compare May 4, 2026 11:14
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from a2dc0e3 to 592c2d8 Compare May 4, 2026 11:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from 4ddafee to 433b30d Compare May 4, 2026 13:20
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch 2 times, most recently from 3605b81 to 844a7fa Compare May 5, 2026 06:53
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch 2 times, most recently from 24e6abc to d6ccf52 Compare May 6, 2026 06:29
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 844a7fa to c9ffb95 Compare May 6, 2026 06:29
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal to graphite-base/13949 May 6, 2026 10:28
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from d6ccf52 to 6dd2ef7 Compare May 6, 2026 10:28
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13949 to 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway May 6, 2026 10:29
@sirandreww-starkware sirandreww-starkware force-pushed the 05-03-apollo_consensus_orchestrator_include_fee_proposal_fri_in_proposal_commitment_hash branch from 6dd2ef7 to 6ecebd0 Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_starknet_client_read_fee_proposal_fri_from_feeder_gateway branch from 7a517f4 to 1292e67 Compare May 6, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants