Skip to content

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob#13985

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposalfrom
05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob
Open

apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into cende blob#13985
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposalfrom
05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented May 6, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 6, 2026

PR Summary

Medium Risk
Changes the cende blob wire format by adding a new snip35_info object, which must stay compatible with the centralized Python recorder and could break ingestion if mismatched.

Overview
Adds SNIP-35 metadata to the cende Aerospike blob by introducing a serialized Snip35Info { fee_proposal_fri: Option<GasPrice> } and wiring it through BlobParameters/AerospikeBlob.

SequencerConsensusContext now forwards the proposer-provided fee_proposal_fri (from ProposalInit) into the blob, and JSON fixtures/tests are updated to assert the new snip35_info.fee_proposal_fri field name and round-trip serialization.

Reviewed by Cursor Bugbot for commit f4453fd. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-06-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_cende_blob branch from 13055bc to f4453fd Compare May 6, 2026 12:00
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_wire_snip-35_fee_proposal_into_build_proposal branch from 81d0db6 to a5a97ee Compare May 6, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants