chore(blockifier): create a file dedicated to l1 handler txs#6380
Merged
Conversation
|
This change is |
Contributor
Author
ArniStarkware
marked this pull request as ready for review
May 8, 2025 07:38
|
Artifacts upload workflows: |
ArniStarkware
requested review from
alonh5
and removed request for
avivg-starkware
May 8, 2025 07:39
alonh5
approved these changes
May 8, 2025
alonh5
left a comment
alonh5
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
ArniStarkware
force-pushed
the
arni/blockifier_l1_txs/create_file_for_l1_txs
branch
from
May 8, 2025 09:09
6307e7f to
f9aa6cb
Compare
This was referenced May 8, 2025
ArniStarkware
deleted the
arni/blockifier_l1_txs/create_file_for_l1_txs
branch
September 11, 2025 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we create a file called
l1_handler_transaction.rs. This file should be parallel toaccount_transaction.rsin the same path.In this PR we create the file and move some functions to that file.
This is towards a greater goal of creating a complete parallel between the files, and moving code out of
transactions.rs, and later changing some business logic of L1 handler transactions.