Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated the homepage with revised organizational metrics, including member count reduction (300 → 70), founding year adjustment (2015 → 2003), modified section headers, redesigned stat visualizations, and altered display values across multiple sections including "By the Numbers," alumni figures, and global reach statistics. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
app/home/page.tsx (2)
87-92: Stalefactsarray and unusedanimatedValuescomputations.The
factsarray still contains old values (e.g., 300 members, €500M capital) that no longer match the displayed UI (70 members, €3B capital). Additionally,animatedValues[0],[1], and[2]are computed but no longer used—onlyanimatedValues[3]is still referenced at line 517.Consider either:
- Removing the unused
factsentries and correspondinganimatedValuescalls, or- Updating
factsto reflect current values and re-enabling the animated displays♻️ Proposed cleanup if only YC animation is needed
const facts = [ - { label: "Members", value: 300, suffix: "+" }, - { label: "Diversity (MINT)", value: 65, suffix: "%" }, - { label: "Capital Raised", value: 500, suffix: "M+", prefix: "€" }, { label: "Members in YC & other top programs", value: 25, suffix: "+" }, ]- const animatedValues = [ - useAnimatedNumber(facts[0].value, !factsView.visible, 1800), - useAnimatedNumber(facts[1].value, !factsView.visible, 1800), - useAnimatedNumber(facts[2].value, !factsView.visible, 1800), - useAnimatedNumber(facts[3].value, !factsView.visible, 1800), - ] + const animatedYCValue = useAnimatedNumber(25, !factsView.visible, 1800)Then update line 517 to use
animatedYCValueinstead ofanimatedValues[3].Also applies to: 150-155
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/home/page.tsx` around lines 87 - 92, The facts array contains stale entries and the animatedValues computations for indexes 0–2 are unused; either update the facts entries to the current numbers (e.g., Members -> 70, Capital Raised -> 3B, etc.) and keep the matching animatedValues logic for each item, or prune the unused facts and remove the corresponding animatedValues[0..2] computations so only the YC-related animation remains. If you choose the latter, delete the unused facts objects and their animation setup, create a single descriptive symbol (e.g., animatedYCValue) for the remaining animation, and replace references to animatedValues[3] with animatedYCValue in the component rendering. Ensure the facts constant and any animation hooks (where animatedValues is defined) are kept consistent with the chosen approach.
519-535: Progress bars are hardcoded and not data-driven.The YC card progress bar (lines 519-522) shows 4/5 filled segments regardless of the animated value (25+), and the Unicorn card (lines 534-535) has a single filled bar hardcoded for the value "1". These visual elements don't dynamically reflect the actual values.
If these are intentional decorative elements, consider adding a brief comment to clarify. Otherwise, consider making them proportional to the displayed values for better data visualization.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/home/page.tsx` around lines 519 - 535, The progress bar segments are hardcoded (the YC card uses [...Array(5)] with i<4 and the Unicorn card renders a single filled bar) and should reflect the actual numeric values; update the JSX that renders the bars to compute a filledCount from the corresponding value (e.g., ycAnimatedValue and unicornValue) and the total segments (e.g., 5), then render [...Array(total)].map((_, i) => <div ... className={i < filledCount ? 'bg-brand-pink' : 'bg-white/10'} />) or factor this into a small helper like renderProgressBars(value, total) used in the YC and Unicorn cards; if the bars are purely decorative instead, add a short comment near the elements documenting that intent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@app/home/page.tsx`:
- Around line 87-92: The facts array contains stale entries and the
animatedValues computations for indexes 0–2 are unused; either update the facts
entries to the current numbers (e.g., Members -> 70, Capital Raised -> 3B, etc.)
and keep the matching animatedValues logic for each item, or prune the unused
facts and remove the corresponding animatedValues[0..2] computations so only the
YC-related animation remains. If you choose the latter, delete the unused facts
objects and their animation setup, create a single descriptive symbol (e.g.,
animatedYCValue) for the remaining animation, and replace references to
animatedValues[3] with animatedYCValue in the component rendering. Ensure the
facts constant and any animation hooks (where animatedValues is defined) are
kept consistent with the chosen approach.
- Around line 519-535: The progress bar segments are hardcoded (the YC card uses
[...Array(5)] with i<4 and the Unicorn card renders a single filled bar) and
should reflect the actual numeric values; update the JSX that renders the bars
to compute a filledCount from the corresponding value (e.g., ycAnimatedValue and
unicornValue) and the total segments (e.g., 5), then render
[...Array(total)].map((_, i) => <div ... className={i < filledCount ?
'bg-brand-pink' : 'bg-white/10'} />) or factor this into a small helper like
renderProgressBars(value, total) used in the YC and Unicorn cards; if the bars
are purely decorative instead, add a short comment near the elements documenting
that intent.
This was referenced Mar 30, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit