Skip to content

Fix: mobile IOS issue#50

Merged
SimonBurmer merged 3 commits intomainfrom
mobile2
Apr 4, 2026
Merged

Fix: mobile IOS issue#50
SimonBurmer merged 3 commits intomainfrom
mobile2

Conversation

@SimonBurmer
Copy link
Copy Markdown
Collaborator

@SimonBurmer SimonBurmer commented Apr 4, 2026

Summary by CodeRabbit

Release Notes

  • Style
    • Applied dark blue background to the application
    • Updated the cities counter from 22 to 21
    • Refreshed the featured cities list in the "START NETWORK" section with new locations
    • Modified how individual cities are highlighted and styled

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
start-munich Ready Ready Preview, Comment Apr 4, 2026 5:42pm

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

Warning

Rate limit exceeded

@SimonBurmer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ec92d52c-2deb-4db0-821b-1823ec24dcb0

📥 Commits

Reviewing files that changed from the base of the PR and between 4bfcc62 and f984064.

📒 Files selected for processing (1)
  • app/home/HomeClient.tsx
📝 Walkthrough

Walkthrough

The changes update styling and content elements on the home page. A background color declaration was added to globals.css, the root layout's body element receives an additional Tailwind background class, and the home page's "START NETWORK" section is updated with a new rolling city list and modified per-city styling logic while reducing the total cities count.

Changes

Cohort / File(s) Summary
Background Styling
app/globals.css, app/layout.tsx
Added explicit background-color declaration to CSS body element and introduced bg-brand-dark-blue Tailwind class to the root layout body element for consistent background theming.
Home Page Content
app/home/page.tsx
Updated cities counter from 22 to 21, replaced the rolling city labels list with a new geographic set including Berlin, Hamburg, Helsinki, London, Paris, and others, and modified color/gradient selection logic from city === 'MUNICH' and i % 5 indexing to city === 'MÜNCHEN' and (i % 21) % 4 indexing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 Hopping through cities, old and new,
From Munich to Madrid, the list rings true,
Modulo magic with twenty-one springs,
Dark blue backgrounds—oh, the joy it brings!
A rabbit's delight in this geographic dance,
Where styling and cities all find their stance. 🌍

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix: mobile IOS issue' is vague and generic, providing no specific information about what was actually fixed in the changeset. Specify the actual issue fixed, such as 'Fix: dark blue background styling for mobile iOS' to clearly convey what changed.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch mobile2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Keep server-component page.tsx from main (ISR caching); port city list
update from mobile2 (21 cities, full START Network list with MÜNCHEN)
into HomeClient.tsx.
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
app/home/page.tsx (1)

754-754: Refactor to remove magic numbers and duplicated city literals.

The city count, style cycle, and render list are manually tied together (21 + duplicated array), which is easy to desync. Derive all three from one source array.

Proposed refactor
-                    <div className="text-5xl sm:text-6xl font-black text-white">21</div>
+                    <div className="text-5xl sm:text-6xl font-black text-white">{networkCities.length}</div>
...
-                  {['BERLIN', 'BARCELONA', 'HAMBURG', 'HELSINKI', 'LAUSANNE', 'LONDON', 'LIMA', 'LISBON', 'MAASTRICHT', 'MEXICO CITY', 'MILANO', 'MÜNCHEN', 'PARIS', 'NÜRNBERG', 'QUITO', 'SAO PAOLO', 'STUTTGART', 'VADUZ', 'VIENNA', 'WARSAW', 'ST. GALLEN', 'BERLIN', 'BARCELONA', 'HAMBURG', 'HELSINKI', 'LAUSANNE', 'LONDON', 'LIMA', 'LISBON', 'MAASTRICHT', 'MEXICO CITY', 'MILANO', 'MÜNCHEN', 'PARIS', 'NÜRNBERG', 'QUITO', 'SAO PAOLO', 'STUTTGART', 'VADUZ', 'VIENNA', 'WARSAW', 'ST. GALLEN'].map((city, i) => (
+                  {networkCitiesMarquee.map((city, i) => (
...
-                        city === 'MÜNCHEN' || (i % 21) % 4 === 3 ? 'text-brand-pink' :
-                        (i % 21) % 4 === 0 ? 'bg-gradient-to-r from-gray-400 to-gray-200 bg-clip-text text-transparent' :
-                        (i % 21) % 4 === 1 ? 'text-white' :
+                        city === 'MÜNCHEN' || (i % networkCities.length) % 4 === 3 ? 'text-brand-pink' :
+                        (i % networkCities.length) % 4 === 0 ? 'bg-gradient-to-r from-gray-400 to-gray-200 bg-clip-text text-transparent' :
+                        (i % networkCities.length) % 4 === 1 ? 'text-white' :
                         'bg-gradient-to-r from-gray-500 to-gray-300 bg-clip-text text-transparent'
// Define once (inside component, before return)
const networkCities = [
  'BERLIN', 'BARCELONA', 'HAMBURG', 'HELSINKI', 'LAUSANNE', 'LONDON', 'LIMA',
  'LISBON', 'MAASTRICHT', 'MEXICO CITY', 'MILANO', 'MÜNCHEN', 'PARIS',
  'NÜRNBERG', 'QUITO', 'SAO PAOLO', 'STUTTGART', 'VADUZ', 'VIENNA', 'WARSAW',
  'ST. GALLEN',
]
const networkCitiesMarquee = [...networkCities, ...networkCities]

Also applies to: 776-783

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/home/page.tsx` at line 754, Replace the hard-coded city count and
duplicate city literals by defining a single source array (e.g. networkCities)
inside the component before the return, use networkCities.length for the
displayed count (replacing the literal "21"), derive the marquee render list as
networkCitiesMarquee = [...networkCities, ...networkCities], and use that array
for any map/render and for computing any style-cycle length so the count, styles
and rendered list are always in sync (update the JSX that shows the count and
any map over cities to reference networkCities / networkCitiesMarquee and adjust
any style cycle logic to use networkCities.length).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/globals.css`:
- Line 80: Add a blank line immediately before the background-color declaration
to satisfy the stylelint rule `declaration-empty-line-before`; locate the
background-color property in globals.css (the line containing "background-color:
`#00002c`;") and insert one empty line above it so the declaration is preceded by
a blank line.

---

Nitpick comments:
In `@app/home/page.tsx`:
- Line 754: Replace the hard-coded city count and duplicate city literals by
defining a single source array (e.g. networkCities) inside the component before
the return, use networkCities.length for the displayed count (replacing the
literal "21"), derive the marquee render list as networkCitiesMarquee =
[...networkCities, ...networkCities], and use that array for any map/render and
for computing any style-cycle length so the count, styles and rendered list are
always in sync (update the JSX that shows the count and any map over cities to
reference networkCities / networkCitiesMarquee and adjust any style cycle logic
to use networkCities.length).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 989d9522-e389-4614-9203-991f382ca224

📥 Commits

Reviewing files that changed from the base of the PR and between 5c982a1 and 4bfcc62.

📒 Files selected for processing (3)
  • app/globals.css
  • app/home/page.tsx
  • app/layout.tsx

Comment thread app/globals.css
}
body {
@apply bg-background text-foreground;
background-color: #00002c;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Address the stylelint failure in this block.

Add an empty line before background-color to satisfy declaration-empty-line-before.

Proposed fix
   body {
     `@apply` bg-background text-foreground;
+
     background-color: `#00002c`;
     font-family: Avenirnextltpro, sans-serif;
     font-weight: 500;
   }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
background-color: #00002c;
body {
`@apply` bg-background text-foreground;
background-color: `#00002c`;
font-family: Avenirnextltpro, sans-serif;
font-weight: 500;
}
🧰 Tools
🪛 Stylelint (17.6.0)

[error] 80-80: Expected empty line before declaration (declaration-empty-line-before)

(declaration-empty-line-before)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/globals.css` at line 80, Add a blank line immediately before the
background-color declaration to satisfy the stylelint rule
`declaration-empty-line-before`; locate the background-color property in
globals.css (the line containing "background-color: `#00002c`;") and insert one
empty line above it so the declaration is preceded by a blank line.

@SimonBurmer SimonBurmer merged commit 67e952b into main Apr 4, 2026
1 of 2 checks passed
@SimonBurmer SimonBurmer deleted the mobile2 branch April 4, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant