-
Notifications
You must be signed in to change notification settings - Fork 0
[SGP-6170] Fixes missing size attribute error.
#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reproducing test case: |
|
To test locally, I did the following: |
|
@abendig This has a CircleCI config, but won't let me configure it... "Contact repo admin" |
|
@abendig Ping. |
|
Should we also have Chris in this repo? Assigned to you because no one else is here. |
abendig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
I set up following on CI and added Chris to the team and this PR.
|
@ChrisAikman This repo may be unfamiliar. And it's not notifying Slack. Hope you see this. |
ChrisAikman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have one question for my curiosity. 👍 ![]()
| setup( | ||
| name="filebrowser_safe", | ||
| version="0.5.0bevy2", | ||
| version="0.5.0.post3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: what is this version convention based on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned, in trying to make the warnings about wrong dependency versions for Mezzanine go away, that Python packages have their own versioning scheme, specified in PEP 440.
Based on experimentation, a post release version was the only way to increment the version, but also satisfy the dependency on >=0.5.0 without a likely collision with a real-live release version. I wanted to get bevy in the version string but it gave warnings every time. Perhaps I didn't read the PEP carefully enough...
|
Sorry, one more question. It seems the forked library is no longer maintained. Is the idea to keep patching the library as needed, or to eventually look elsewhere? |
|
Not sure what led you to think it is no longer maintained. It doesn't get changes often. And we've forked the version that the Mezzanine guy forked from the original project. So it is a bit unclear to me how maintained it is. That said, we are operating on an older version here because of the speed-up necessary for our Softlayer storage, so technically our |
ChrisAikman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, somehow clicked Request changes instead of Approve. For real this time: 👍 ![]()
Fix cs specification that is breaking compilemessages command

sizeattribute toFileObjectto fulfill expectations of the Mezzanine 4.3.1 blog feed.filesize.