Conversation
Modified all .tsx within /settings/tasks
Rest of the PatchComponent changes.
WithoutPants
left a comment
WithoutPants
left a comment
There was a problem hiding this comment.
It might be worth looking over the non-exported components to see their value in being patchable/usable in plugins. It may not make sense to do them all.
| } | ||
|
|
||
| const LogElement: React.FC<ILogElementProps> = PatchComponent( | ||
| "LogElement", |
There was a problem hiding this comment.
Where a component is not exported, it usually indicates that it's part of a larger component. In these cases, it's ideal to name these as a sub-component of the parent component. In this case, since this is a child component of SettingsLogsPanel, I think this should be SettingsLogsPanel.LogElement. This helps reduce potential duplicate component labels.
| count?: number; | ||
| }> | ||
| > = ({ entityType, count, children }) => { | ||
| > = PatchComponent("ScraperTable", ({ entityType, count, children }) => { |
There was a problem hiding this comment.
As above, I think this should be SettingsScrapingPanel.ScraperTable. I won't mark all of these, but please do a pass and correct the non-exported ones.
DogmaDragon
left a comment
DogmaDragon
left a comment
There was a problem hiding this comment.
Changes needs to be documented in https://github.com/stashapp/stash/blob/develop/ui/v2.5/src/docs/en/Manual/UIPluginApi.md.
3 participants
Modified all .tsx within /settings/tasks