Align release Dockerfiles with Go 1.25 for backend builds.#6889
Merged
WithoutPants merged 1 commit intostashapp:developfrom May 5, 2026
Merged
Conversation
The x86_64 and CUDA backend stages still used golang:1.24.3 while go.mod requires Go 1.25, which broke make docker-build under GOTOOLCHAIN=local. Bump both images to golang:1.25.9 to match docker/compiler/Dockerfile and PR stashapp#6869. Verified with: make docker-build Fixes stashapp#6887 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
I hit an issue earlier trying to build from source to test a different bugfix patch. In chasing this down I found that a merge late last week made it so the docker wouldn't build with our new go version bump. This is just catching up that bump. Very straight forward fix - 2 image replacements in the dockerfile. |
feederbox826
approved these changes
May 5, 2026
Member
|
CUDA also probably needs a bump to node 24 |
Stash-KennyG
added a commit
to Stash-KennyG/stash
that referenced
this pull request
May 5, 2026
…6889) The x86_64 and CUDA backend stages still used golang:1.24.3 while go.mod requires Go 1.25, which broke make docker-build under GOTOOLCHAIN=local. Bump both images to golang:1.25.9 to match docker/compiler/Dockerfile and PR stashapp#6869. Verified with: make docker-build Fixes stashapp#6887 Co-authored-by: KennyG <kennyg@kennyg.com> Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 3afe292)
Stash-KennyG
pushed a commit
to Stash-KennyG/stash
that referenced
this pull request
May 5, 2026
…tashapp#6889)" This reverts commit d9d5023.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The x86_64 and CUDA backend stages still used golang:1.24.3 while go.mod requires Go 1.25, which broke make docker-build under GOTOOLCHAIN=local. Bump both images to golang:1.25.9 to match docker/compiler/Dockerfile and PR #6869.
Verified with: make docker-build
Fixes #6888