-
-
Notifications
You must be signed in to change notification settings - Fork 601
[6.x] Alert component #13599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Alert component #13599
Conversation
jasonvarga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a heading prop. I thought that would be pretty useful so you dont need to start importing Heading and Description components manually.
I also made it so when you use the text prop, it'll put it into a Description component for consistency.
However I noticed it ends up with slightly different colors than when using just the span. Check it out. Here I've got both a Description and then the span just to illustrate it:
<Description :text="text" />
+<span v-html="text" />
Also, it messes with the padding/spacing:
<Alert text="This is a default alert message" />
<Alert><Description>This is a default alert message</Description></Alert>
Good idea!
Fixed :)
I can't see this. Did you hard refresh the page after changing things? This is one of those instances where Vite doesn't seem to inject the changes unless you refresh |
Description of the Problem
Currently, there's no alert component
What this PR Does
How to Reproduce
cp/playground, where you'll find various alert demos, shown in the screenshot above.Dashboard demoand go tocp/dashboardto see the component in situ.