[6.x] Improve Combobox performance #13625
Merged
+16
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the performance of the Combobox component, specifically when opening/closing the dropdown and searching through lots of options.
Improvements:
isSelectedmethod to use.some()instead of.filter()to avoid unnecessary comparisons.filteredOptionsmeasureOptionWidthsmethod now only measures the width of the three options with the longest labels, not every option.force-mountprop for longer dropdowns, allowing options to be rendered & measurements to happen before the user clicks to open the dropdown.min-heightwas dependant on theoptionsprop, notfilteredOptions.Closes #13615