[6.x] Remove the inset style for relationship fields to make dark mode more consistent #13784
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Problem
In dark mode, relationship entry bars have a sunken aesthetic, like this:
(Before)
It's been commented that this feels inconsistent/off as per #13619.
The sunken bars were part of our design exploration for dark mode. Since they're rarely used, I think it's fine just to make them the same aesthetic as light mode until we touch the relationship field again.
We had an internal discussion in our design channel about this and agreed this way forward.
(After)
What this PR Does
How to Reproduce