-
-
Notifications
You must be signed in to change notification settings - Fork 607
[6.x] Copy to clipboard improvements and fixes throughout the CP #13791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I made some changes: Avoided passing enabled+value to the composable. They weren't reactive. If the value changed it would copy the original. If you had multiple things to copy in a component, you'd need to new up the composable multiple times. I made the If you have multiple things to copy in the same component, the I reverted the UI of recovery codes from the center aligned single column textarea back to the two columns with a button - but the button works now thanks to you. |
This initially started out as just fixing one thing by making
:valueinto:model-valueso the two factor setup secret actually gets copied to the clipboard which did not work. Then saw room for improvement throughout the CP in other places where stuff gets copied to the clipboard. Some things were broken and there was inconsistency as well.So PR includes:
copyablecomposable and adding it to theInputandTextareacomponents.Textareadidn't have this at all before.RecoveryCodesModalto useTextareawith thecopyablefunctionality. Had duplicate clipboard logic in there.Releasecomponent where the copy button did not work and also wasn't visible against the dark background.copyableprop.