[6.x] Preload replicator meta/defaults when blueprint doesn't have a FQH#13951
Merged
jasonvarga merged 1 commit into6.xfrom Feb 17, 2026
Merged
[6.x] Preload replicator meta/defaults when blueprint doesn't have a FQH#13951jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
morhi
reviewed
Feb 16, 2026
|
|
||
| if (this.meta.new?.hasOwnProperty(set)) { | ||
| let meta = this.meta.new[set]; | ||
| let defaults = this.meta.defaults[set]; |
Contributor
There was a problem hiding this comment.
Hey Duncan! Just wondering if this line would introduce similar effects of #13955 ?
Member
Author
There was a problem hiding this comment.
We actually already do a deep clone of the set's defaults here:
The addSet() method calls fetchSet(), then once its got the set, it calls _addSet() which has the deep clone logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request brings back preloading meta/defaults for Bard and Replicator fields, but only when the blueprint doesn't have a fully-qualified handle.
In #13427, we made it so set meta/defaults are only loaded when you add a new set, reducing the JSON payload sent down to clients. Adding a new set would trigger a network request to get the set and do the necessary processing.
However, the
ReplicatorSetControllerrequires a blueprint's fully-qualified handle, which on-the-fly blueprints (like addon settings ones) don't have. This PR ensures we fallback to the old and possibly slower behaviour in those cases.Closes #13946