Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where creating a Set inside Bard would cause the set picker menu to appear at the very top of the content, instead of inline where the + button was clicked.
This was happening because the
Primitivecomponent (introduced in #14290) was rendering a default wrapper element (a<span>) around the trigger slot. This extra element became the popover's trigger reference for floating-ui positioning, instead of the actual transformed trigger element (the absolute div withtranslateY). Since the span was at its default position (top of the editor), the popover appeared there.This PR fixes it by adding
as-childto thePrimitivecomponents, which prevents them from rendering their own DOM element and instead merges props and event handlers with the child element, preserving correct trigger positioning for floating-ui.Fixes #14311
Caused by #14290