[6.x] Fix CP Nav active state when trailing slashes are enforced#14363
Merged
jasonvarga merged 1 commit into6.xfrom Mar 26, 2026
Merged
[6.x] Fix CP Nav active state when trailing slashes are enforced#14363jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where enforcing trailing slashes would break the CP nav active state and breadcrumbs on nested pages (eg. entry edit page, asset browser).
This was happening because the
generateActivePatternForCpUrl()method generates a regex pattern for active state detection, but when trailing slashes are enforced, the$relativeUrlcontains a trailing slash, which breaks the regex.This PR fixes it by stripping trailing slashes from the relative URL before generating the regex pattern.
Note: I couldn't replicate this locally w/ Herd, but I could on a Forge-provisioned server with our recommended Nginx rules.
Fixes #14126