[5.x] Harden query value resolution#14476
Merged
jasonvarga merged 10 commits into5.xfrom Apr 13, 2026
Merged
Conversation
duncanmcclean
changed the title
getQueryableValuegetQueryableValue()
Remove redundant method_exists check since the allowlist already contains only known methods. Rename methodIsSafeToQuery to queryableMethods, returning the array directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jasonvarga
changed the title
getQueryableValue()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit method allowlists to getQueryableValue() across various classes, replacing the previous open-ended method_exists() check. It also implements ContainsQueryableValues on additional classes that flow through ResolveValue, and adds a method denylist as an extra safety net.