[6.x] Fix Eloquent user merge setting roles and groups as model attributes#14526
Merged
jasonvarga merged 1 commit into6.xfrom Apr 21, 2026
Merged
[6.x] Fix Eloquent user merge setting roles and groups as model attributes#14526jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where calling
merge()on an Eloquent user would cause aColumn not foundSQL error forrolesandgroups.This was happening because
merge()round-trips throughdata()— the getter injectsrolesandgroupsfrom their relationship tables, but the setter passes every key throughset(), which assigns directly to the Eloquent model. When the model saves, it tries to writerolesandgroupscolumns that don't exist.This PR fixes it by stripping
rolesandgroupsfrom the data before passing it back through the setter, since they're managed via their own relationship tables and should never be set as model attributes.Fixes duncanmcclean/statamic-cargo#176