[6.x] Fix updateChildPageUris empty check never short-circuiting#14547
Merged
jasonvarga merged 1 commit into6.xfrom Apr 24, 2026
Merged
[6.x] Fix updateChildPageUris empty check never short-circuiting#14547jasonvarga merged 1 commit into6.xfrom
updateChildPageUris empty check never short-circuiting#14547jasonvarga merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where saving a structured entry would rewrite URIs for every entry in the collection, even when the entry has no child pages.
This was happening because
empty()was being used to check if theflattenedPagescollection was empty. Sinceempty()on a Collection object always returnsfalse(it's a non-null object), the early return never triggered. This meantupdateEntryUriswas called with an empty Collection, and in the eloquent driver, thewhereInfilter was skipped — causing every entry's URI to be recomputed.This PR fixes it by using the Collection's
isEmpty()method instead ofempty().Fixes #14546