Composer package versions#3335
Merged
jasonvarga merged 1 commit intomasterfrom Mar 4, 2021
Merged
Conversation
jesseleite
reviewed
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
$this->isUpdatingTo('3.1')wouldn't work but3.1.0would.This also scraps our version normalizing code in favor of Composer's. They already have a full-fledged thing.
But since their method normalizes the versions to 4 digits (e.g.
3.0.0.0), I've made a separategetNormalizedInstalledVersionthat does the normalizing.getInstalledVersionjust uses whatever is actually installed with Composer.This lets us use the normalized version for
version_compare, but the regular one for displaying.