[5.x] Ensure expectation count isnt negative if Version is not called#9863
Merged
jasonvarga merged 2 commits intostatamic:masterfrom Apr 11, 2024
Merged
Conversation
duncanmcclean
approved these changes
Apr 11, 2024
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since eloquent driver was updated to use AddonTestCase its being showing warning about skipping tests, which I've worked out is due to a negative assertion count.
It seems to be due to it not triggering a call to version, so the simple fix is to allow this to be called zero or more time.