[5.x] Prevent excessive nocache cache growth#9999
Merged
jasonvarga merged 1 commit intostatamic:masterfrom May 7, 2024
JohnathonKoster:prevent-excessive-nocache-cache-growth
Merged
[5.x] Prevent excessive nocache cache growth#9999jasonvarga merged 1 commit intostatamic:masterfrom JohnathonKoster:prevent-excessive-nocache-cache-growth
jasonvarga merged 1 commit intostatamic:masterfrom
JohnathonKoster:prevent-excessive-nocache-cache-growth
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the randomness within nocache region keys, and instead relies on the session's URL and an incrementing value to determine the nocache region key. This allows the nocache regions to be unique within each session, but also not get regenerated on each request.
An easy way to test this behavior is to run
php please ssg:generateon a decently sized site that contains{{ nocache }}{{ /nocache }}somewhere. Subsequent SSG runs should not cause thestorage/statamic/static-urls-cachefolder size to double on each run.