Fix end-of-file crackle on sound effects#111
Merged
jasonvarga merged 1 commit intomasterfrom Apr 16, 2026
Merged
Conversation
The source MP3s had ~8 samples clipped to full-scale at the end, producing an audible click. Replaced with WAVs where the trailing 20ms is trimmed and a 5ms linear fade-out is applied. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
buddy-inandbuddy-outcollaboration sound effects had an audible click/crackle at the very end. Inspecting the PCM showed that the last ~8 samples in each source MP3 were clipped to near full-scale (e.g.-32768) — a hard discontinuity against the otherwise quiet tail of each sound. The artifact was reproducible in QuickTime as well as the browser, confirming it was baked into the files rather than a playback issue.Changes
resources/audio/buddy-in.mp3andbuddy-out.mp3with.wavversions that have the trailing 20 ms trimmed and a 5 ms linear fade-out applied to avoid reintroducing a click.resources/js/Workspace.jsto point at the new.wavfiles.Switching to WAV (rather than re-encoding to MP3) avoids another lossy round-trip for what are very short UI sounds; the combined size delta is negligible.
Test plan
resources/audio/buddy-in.wavandbuddy-out.wavin QuickTime — confirm no crackle at the end.🤖 Generated with Claude Code