Skip to content

Fix SQLite skipped tests #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix SQLite skipped tests #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Data/Entries/EntryQueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ public function entries_are_found_using_or_where_not_between()
/** @test **/
public function entries_are_found_using_where_json_contains()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -404,7 +404,7 @@ public function entries_are_found_using_where_json_contains()
/** @test **/
public function entries_are_found_using_where_json_doesnt_contain()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -428,7 +428,7 @@ public function entries_are_found_using_where_json_doesnt_contain()
/** @test **/
public function entries_are_found_using_or_where_json_contains()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -447,7 +447,7 @@ public function entries_are_found_using_or_where_json_contains()
/** @test **/
public function entries_are_found_using_or_where_json_doesnt_contain()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand Down
8 changes: 4 additions & 4 deletions tests/Data/Taxonomies/TermQueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ private function createWhereDateTestTerms()
/** @test **/
public function terms_are_found_using_where_json_contains()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -506,7 +506,7 @@ public function terms_are_found_using_where_json_contains()
/** @test **/
public function terms_are_found_using_where_json_doesnt_contain()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -531,7 +531,7 @@ public function terms_are_found_using_where_json_doesnt_contain()
/** @test **/
public function terms_are_found_using_or_where_json_contains()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand All @@ -551,7 +551,7 @@ public function terms_are_found_using_or_where_json_contains()
/** @test **/
public function terms_are_found_using_or_where_json_doesnt_contain()
{
if (config('database.default') === 'sqlite') {
if ($this->isUsingSqlite()) {
$this->markTestSkipped('SQLite doesn\'t support JSON contains queries');
}

Expand Down
7 changes: 7 additions & 0 deletions tests/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,4 +211,11 @@ public function runMigrationsForUUIDEntries()
$migration = require __DIR__.'/../database/migrations/create_entries_table_with_string_ids.php.stub';
$migration->up();
}

protected function isUsingSqlite()
{
$connection = config('database.default');

return config("database.connections.{$connection}.driver") === 'sqlite';
}
}