Fix GenerateReportCommand not found when generating reports#557
Merged
duncanmcclean merged 2 commits into7.xfrom May 5, 2026
Merged
Fix GenerateReportCommand not found when generating reports#557duncanmcclean merged 2 commits into7.xfrom
duncanmcclean merged 2 commits into7.xfrom
Conversation
Statamic's AddonServiceProvider only auto-discovers commands when running in the console. When the report is generated via the CP (using Artisan::queue with the sync driver), the command isn't registered, causing a CommandNotFoundException. Fixes #556 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where clicking "Generate Report" in the Control Panel throws a
CommandNotFoundExceptionforstatamic:seo-pro:generate-report.This was happening because Statamic's
AddonServiceProvideronly auto-discovers commands whenrunningInConsole()is true. When the report is generated via a web request (usingArtisan::queuewith thesyncqueue driver), the command was never registered.This PR fixes it by explicitly registering
GenerateReportCommandin the service provider'sregister()method, which runs regardless of context.Fixes #556