Missing data#23
Merged
Merged
Conversation
added 2 commits
August 27, 2025 11:47
…ant covariate is missing, remove the observation that it is missing from then proceed. Run tests for these features.
Collaborator
Author
|
@adw96 message now added when we remove incomplete cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #21
Although
raoBusthas ways of dealing with missing data (silently dropping incomplete cases, as is done byglmandlm),enviromtxused to throw an error whenyy,xx,xstar, or a relevant covariate were missing, because there was an issue with differences in lengths of the data after incomplete cases were dropped and the offset which was saved as a vector without that case being dropped. In this PR, we manually drop cases that are missing values foryy,xx,xstar, or a relevant covariate. We also throw errors ifwtsorreplicatesare provided but have a missing value. We test all of this new functionality in "test-missing-data.R". We document this behavior in theenviro_dfparameter documentation infit_mgx_model()and index the version number to denote a bug fix.