Add optional centering of covariates#24
Conversation
Update user inputs
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
adw96
left a comment
There was a problem hiding this comment.
This all looks great. I made a minor change to clarify why one might use center... but really this looks good.
Did we increment the major release earlier and just not add a NEWS then?
Confirming we are not incrementing the version number now?
I'm happy for you to merge when ready
|
Yes, I added a NEWS that really refers to the previous release, and did not increment the version here (it was originally because I was thinking centering would be TRUE by default which would be another breaking change so instead of having two major releases back to back just combine them. But now it's only a minor update). I updated this now to instead update this version as a minor release and separate out these two pieces in the NEWS.md. |
controllist, which we can later build on with user optionscontrol$center = FALSE