Skip to content

Merge pivot before cyclic imports force big file changes#128

Closed
wisnesky wants to merge 6 commits into
masterfrom
ryan4
Closed

Merge pivot before cyclic imports force big file changes#128
wisnesky wants to merge 6 commits into
masterfrom
ryan4

Conversation

@wisnesky
Copy link
Copy Markdown
Contributor

@wisnesky wisnesky commented Dec 3, 2018

No description provided.

@wisnesky wisnesky requested review from epost and marcosh December 3, 2018 20:03
Comment thread examples/Petri.aql
foreign_keys
place : Input -> Place
trans : Input -> Trans
place : Output -> Place
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the parses does not allow duplicate bingings. If I try to run this example with stack exec aql-exe I get the following error message Eval Error in Net: Duplicate binding: "trans"

Comment thread src/Language/Instance.hs
Comment thread src/Language/Instance.hs
Comment thread src/Language/Instance.hs Outdated
Comment thread src/Language/Instance.hs Outdated
Comment thread src/Language/Instance.hs Outdated
Comment thread src/Language/Parser/Instance.hs Outdated
@epost
Copy link
Copy Markdown
Member

epost commented Aug 5, 2019

Thanks Ryan! I fixed the merge conflicts that have arisen since you contributed this in #147, so closing this.

@epost epost closed this Aug 5, 2019
epost added a commit that referenced this pull request Aug 7, 2019
epost added a commit that referenced this pull request Aug 7, 2019
* more work on pivot (Ryan)

* pivot is essentially done but finishing it causes cyclic imports

* code formatting and styling #38

* Rename AQL stuff in tests to CQL. #146

* Address @marcosh's comments from #128. #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants