Skip to content

Add pivot feature. #146#147

Merged
epost merged 9 commits into
masterfrom
ryan4-merge-attempt-2
Aug 7, 2019
Merged

Add pivot feature. #146#147
epost merged 9 commits into
masterfrom
ryan4-merge-attempt-2

Conversation

@epost
Copy link
Copy Markdown
Member

@epost epost commented Aug 5, 2019

This takes the pivot feature from ryan4 branch (PR #128) and resolves merge conflicts and other issues as needed.

@epost epost mentioned this pull request Aug 5, 2019
@epost epost changed the title Add pivot feature. #1 Add pivot feature. #146 Aug 5, 2019
@epost epost mentioned this pull request Aug 7, 2019
18 tasks
@epost
Copy link
Copy Markdown
Member Author

epost commented Aug 7, 2019

Hi @wisnesky, could you sign off your contribution on this PR using the clahub details link? When that's done, we can merge this. Thanks!

@wisnesky
Copy link
Copy Markdown
Contributor

wisnesky commented Aug 7, 2019 via email

@epost
Copy link
Copy Markdown
Member Author

epost commented Aug 7, 2019

@wisnesky Hmm, I'm not sure; had you signed off before? Maybe it's because this is a new PR rebased on master?

@wisnesky
Copy link
Copy Markdown
Contributor

wisnesky commented Aug 7, 2019 via email

@epost
Copy link
Copy Markdown
Member Author

epost commented Aug 7, 2019

@wisnesky Oh! Right, that's the reason then; clahub is an automated service that checks whether every contributor has agreed to the CLA.

@epost
Copy link
Copy Markdown
Member Author

epost commented Aug 7, 2019

So @wisnesky, would you mind signing off here so that this PR can be merged? CLA Hub is preventing the merge from happening, probably because it doesn't know about the PDF. (This should be a one-time thing only, if I'm not mistaken.)

@wisnesky
Copy link
Copy Markdown
Contributor

wisnesky commented Aug 7, 2019 via email

@epost
Copy link
Copy Markdown
Member Author

epost commented Aug 7, 2019

Thanks @wisnesky! 👍 That is my understanding too. @wires, could you chime in?

@wires
Copy link
Copy Markdown
Member

wires commented Aug 7, 2019

👍 yeah thats correct Ryan, it is not possible with that app to pre-auth people, so everyone has to sign it again. I tried to keep the CLA minimal as a workaround, instead of copying all the legal stuff from the contract verbatim

@epost epost merged commit b7b6e91 into master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants