Add pivot feature. #146#147
Merged
Merged
Conversation
code formatting and styling #38
Closed
Member
Author
Contributor
|
Did something change? Why are these pivot contributions triggering a new (re?) licensing request but not any other the other contributions?
… On Aug 7, 2019, at 3:35 PM, Erik Post ***@***.***> wrote:
Hi @wisnesky <https://github.com/wisnesky>, could you sign off your contribution on this PR using the clahub details <https://www.clahub.com/agreements/statebox/cql> link? When that's done, we can merge this. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#147?email_source=notifications&email_token=AA2QKN3ZB624W2U4RIUVOS3QDMPZLA5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZPOQQ#issuecomment-519239490>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2QKN5DCIAG2BH5PVAOQILQDMPZLANCNFSM4IJLOFKA>.
|
Member
Author
|
@wisnesky Hmm, I'm not sure; had you signed off before? Maybe it's because this is a new PR rebased on master? |
Contributor
|
Yeah, I signed a PDF over a year ago, not anything online.
… On Aug 7, 2019, at 4:03 PM, Erik Post ***@***.***> wrote:
@wisnesky <https://github.com/wisnesky> Hmm, I'm not sure; had you signed off before? Maybe it's because this is a new PR rebased on master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#147?email_source=notifications&email_token=AA2QKN474IFEEXDLTGGFV7LQDMTC7A5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZRU5Q#issuecomment-519248502>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2QKN42J6SNQIHA2QVQD7TQDMTC7ANCNFSM4IJLOFKA>.
|
Member
Author
Member
Author
Contributor
|
OK, but for the record I interpret this to mean the original agreement is still in place, and this is a technical fix.
… On Aug 7, 2019, at 5:10 PM, Erik Post ***@***.***> wrote:
So @wisnesky <https://github.com/wisnesky>, would you mind signing off here <https://www.clahub.com/agreements/statebox/cql> so that this PR can be merged? CLA Hub is preventing the merge from happening, probably because it doesn't know about the PDF. (This should be a one-time thing only, if I'm not mistaken.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#147?email_source=notifications&email_token=AA2QKN5L2XDZYXWESRVIMULQDM25BA5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZXANY#issuecomment-519270455>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA2QKN6WSQ56KIWSUQGG4A3QDM25BANCNFSM4IJLOFKA>.
|
Member
Author
Member
|
👍 yeah thats correct Ryan, it is not possible with that app to pre-auth people, so everyone has to sign it again. I tried to keep the CLA minimal as a workaround, instead of copying all the legal stuff from the contract verbatim |
wires
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the pivot feature from ryan4 branch (PR #128) and resolves merge conflicts and other issues as needed.