File logging support via --log-file option#682
Merged
Conversation
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for File Logging to write log records to a file on disk, in addition to
stderr. It is useful for production deployments wherestderris captured by a service manager, but a durable on-disk copy is also required.--log-file <PATH>(SERVER_LOG_FILE): Filesystem path to stream log records to in addition to stderr. Missing parent directories are created on startup. The file is opened in append mode.The file uses the format selected by
--log-format(jsonby default) and the level selected by--log-level.ANSI escape codes are always disabled for file output regardless of
--log-with-ansi, so the file stays parsable.Example
static-web-server \ --port 8787 \ --root ./my-public-dir \ --log-level info \ --log-format json \ --log-file /var/log/sws/server.logNote that SWS does not rotate the file itself, so an external tool such as logrotate could be used.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):