Use go expression consistently by pedropombeiro · Pull Request #8529 · status-im/status-legacy

pedropombeiro · 2019-07-04T15:17:33Z

This PR introduces some changes that were required by feature/nix-gradle-and-mobile-node2nix, but do not depend on that branch, so far the sake of simplicity I'm opening a separate PR.

Summary

This PR:

guarantees that we reuse the same go Nix expression everywhere.
cleans up some files.
ensures that we don't pull in the Android SDK in status-go expression if we're building for iOS.

Review notes

Testing notes

No changes to the app were performed in this PR.

status: ready

ghost · 2019-07-04T15:17:39Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-07-04T15:18:06Z

Jenkins Builds

Click to see older builds (40)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`3f4bb34`	#1	2019-07-04 15:18:06	~25 sec	`android-e2e`	📄 log
❌	`3f4bb34`	#1	2019-07-04 15:18:11	~29 sec	`android`	📄 log
❌	`3f4bb34`	#1	2019-07-04 15:18:17	~32 sec	`macos`	📄 log
❌	`3f4bb34`	#1	2019-07-04 15:18:23	~39 sec	`linux`	📄 log
❌	`3f4bb34`	#1	2019-07-04 15:18:34	~48 sec	`windows`	📄 log

✔️	`0510737`	#2	2019-07-04 15:33:35	~13 min	`macos`	📦 dmg
✔️	`0510737`	#2	2019-07-04 15:34:32	~14 min	`ios`	📦 ipa
✔️	`0510737`	#2	2019-07-04 15:36:03	~16 min	`linux`	📦 App
✔️	`0510737`	#2	2019-07-04 15:39:13	~19 min	`android-e2e`	📦 apk
✔️	`0510737`	#2	2019-07-04 15:39:46	~19 min	`windows`	📦 exe
✔️	`0510737`	#2	2019-07-04 15:39:58	~20 min	`android`	📦 apk

✔️	`4d5833b`	#3	2019-07-04 15:51:43	~10 min	`ios`	📦 ipa
✔️	`4d5833b`	#3	2019-07-04 15:52:12	~11 min	`macos`	📦 dmg
✔️	`4d5833b`	#3	2019-07-04 15:53:58	~13 min	`android-e2e`	📦 apk
✔️	`4d5833b`	#3	2019-07-04 15:56:34	~15 min	`linux`	📦 App
✔️	`4d5833b`	#3	2019-07-04 15:58:22	~17 min	`windows`	📦 exe
✔️	`4d5833b`	#3	2019-07-04 16:01:48	~21 min	`android`	📦 apk

✔️	`f74d3ae`	#4	2019-07-04 16:18:52	~10 min	`ios`	📦 ipa
✔️	`f74d3ae`	#4	2019-07-04 16:20:52	~12 min	`android`	📦 apk
✔️	`f74d3ae`	#4	2019-07-04 16:23:11	~15 min	`macos`	📦 dmg
✔️	`f74d3ae`	#4	2019-07-04 16:24:47	~16 min	`windows`	📦 exe
✔️	`f74d3ae`	#4	2019-07-04 16:26:20	~18 min	`linux`	📦 App

✔️	`42e859c`	#5	2019-07-04 16:42:22	~13 min	`android-e2e`	📦 apk
✔️	`42e859c`	#5	2019-07-04 16:42:43	~13 min	`ios`	📦 ipa
✔️	`42e859c`	#5	2019-07-04 16:43:32	~14 min	`macos`	📦 dmg
✔️	`42e859c`	#5	2019-07-04 16:44:44	~15 min	`windows`	📦 exe
✔️	`42e859c`	#5	2019-07-04 17:00:14	~31 min	`linux`	📦 App
✔️	`42e859c`	#5	2019-07-04 17:07:33	~38 min	`android`	📦 apk

✔️	`9d4e34e`	#7	2019-07-04 21:03:45	~10 min	`android`	📦 apk
✔️	`9d4e34e`	#7	2019-07-04 21:04:19	~11 min	`ios`	📦 ipa
✔️	`9d4e34e`	#7	2019-07-04 21:04:53	~11 min	`linux`	📦 App
✔️	`9d4e34e`	#7	2019-07-04 21:06:44	~13 min	`macos`	📦 dmg
✔️	`9d4e34e`	#7	2019-07-04 21:07:05	~13 min	`windows`	📦 exe
✔️	`9d4e34e`	#7	2019-07-04 21:23:32	~30 min	`android-e2e`	📦 apk

✔️	`9e42930`	#8	2019-07-05 11:55:05	~11 min	`android-e2e`	📦 apk
✔️	`9e42930`	#8	2019-07-05 11:55:39	~11 min	`android`	📦 apk
✔️	`9e42930`	#8	2019-07-05 11:55:48	~11 min	`ios`	📦 ipa
✔️	`9e42930`	#8	2019-07-05 11:55:59	~11 min	`macos`	📦 dmg
✔️	`9e42930`	#8	2019-07-05 11:59:24	~15 min	`linux`	📦 App
✔️	`9e42930`	#8	2019-07-05 12:00:39	~16 min	`windows`	📦 exe

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7c1f32f`	#9	2019-07-05 12:31:49	~10 min	`android`	📦 apk
✔️	`7c1f32f`	#9	2019-07-05 12:32:18	~10 min	`ios`	📦 ipa
✔️	`7c1f32f`	#9	2019-07-05 12:32:48	~11 min	`macos`	📦 dmg
✔️	`7c1f32f`	#9	2019-07-05 12:33:51	~12 min	`windows`	📦 exe
✔️	`7c1f32f`	#9	2019-07-05 12:35:24	~13 min	`android-e2e`	📦 apk
✔️	`7c1f32f`	#9	2019-07-05 12:37:10	~15 min	`linux`	📦 App

✔️	`cef9f10`	#10	2019-07-05 12:55:42	~12 min	`android-e2e`	📦 apk

ghost · 2019-07-05T12:21:23Z

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

statustestbot · 2019-07-05T12:32:28Z

100% of end-end tests have passed

Total executed tests: 44
Failed tests: 0
Passed tests: 44

Passed tests (44)

Click to expand

1. test_block_user_from_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
2. test_filters_from_daap
Device sessions Device 1: Steps, video, logs
3. test_copy_and_paste_messages
Device sessions Device 1: Steps, video, logs
4. test_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
5. test_request_and_receive_tokens_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
6. test_deploy_contract_from_daap
Device sessions Device 1: Steps, video, logs
7. test_open_transaction_on_etherscan
Device sessions Device 1: Steps, video, logs
8. test_public_chat_messaging
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
9. test_long_press_to_delete_1_1_chat
Device sessions Device 1: Steps, video, logs
10. test_password_in_logcat_sign_in
Device sessions Device 1: Steps, video, logs
11. test_sign_typed_message
Device sessions Device 1: Steps, video, logs
12. test_logcat_send_transaction_from_daap
Device sessions Device 1: Steps, video, logs
13. test_send_message_in_group_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
14. test_logcat_send_transaction_from_wallet
Device sessions Device 1: Steps, video, logs
15. test_send_token_with_7_decimals
Device sessions Device 1: Steps, video, logs
16. test_modify_transaction_fee_values
Device sessions Device 1: Steps, video, logs
17. test_send_eth_from_wallet_to_address
Device sessions Device 1: Steps, video, logs
18. test_manage_assets
Device sessions Device 1: Steps, video, logs
19. test_logcat_send_transaction_in_1_1_chat
Device sessions Device 1: Steps, video, logs
20. test_request_and_receive_eth_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
21. test_long_press_to_delete_public_chat
Device sessions Device 1: Steps, video, logs
22. test_send_emoji
Device sessions Device 1: Steps, video, logs
23. test_search_chat_on_home
Device sessions Device 1: Steps, video, logs
24. test_logcat_recovering_account
Device sessions Device 1: Steps, video, logs
25. test_send_tokens_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
26. test_network_mismatch_for_send_request_commands
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
27. test_logcat_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
28. test_switch_users_and_add_new_account
Device sessions Device 1: Steps, video, logs
29. test_send_stt_from_wallet
Device sessions Device 1: Steps, video, logs
30. test_send_eth_in_1_1_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
31. test_login_with_new_account
Device sessions Device 1: Steps, video, logs
32. test_send_eth_from_wallet_to_contact
Device sessions Device 1: Steps, video, logs
33. test_add_contact_from_public_chat
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_send_two_transactions_one_after_another_in_dapp
Device sessions Device 1: Steps, video, logs
35. test_password_in_logcat_creating_account
Device sessions Device 1: Steps, video, logs
36. test_backup_recovery_phrase
Device sessions Device 1: Steps, video, logs
37. test_offline_status
Device sessions Device 1: Steps, video, logs
38. test_open_google_com_via_open_dapp
Device sessions Device 1: Steps, video, logs
39. test_unread_messages_counter_public_chat
Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs
40. test_sign_message_from_daap
Device sessions Device 1: Steps, video, logs
41. test_user_can_remove_profile_picture
Device sessions Device 1: Steps, video, logs
42. test_share_contact_code_and_wallet_address
Device sessions Device 1: Steps, video, logs
43. test_refresh_button_browsing_app_webview
Device sessions Device 1: Steps, video, logs
44. test_backup_recovery_phrase_warning_from_wallet
Device sessions Device 1: Steps, video, logs

Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>

ghost · 2019-07-05T12:43:14Z

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

ghost · 2020-01-15T13:58:13Z

mobile_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

pedropombeiro added skip-manual-qa labels Jul 4, 2019

pedropombeiro requested a review from jakubgs July 4, 2019 15:17

pedropombeiro requested a review from vkjr as a code owner July 4, 2019 15:17

pedropombeiro self-assigned this Jul 4, 2019

pedropombeiro changed the title ~~Fix/consistent golang version~~ Use go expression consistently Jul 4, 2019

pedropombeiro force-pushed the fix/consistent-golang-version branch from 3f4bb34 to 0510737 Compare July 4, 2019 15:19

pedropombeiro requested a review from a team as a code owner July 4, 2019 15:40

pedropombeiro force-pushed the fix/consistent-golang-version branch 3 times, most recently from 5eff7a8 to 9d4e34e Compare July 4, 2019 20:52

Pedro Pombeiro added 5 commits July 5, 2019 13:40

Ensure a consistent golang version is used throughout Nix

9b7b5b9

Only bring in Android dependencies in gomobile if targetting Android

8d8ef4d

Clean up some nix files

48c7f92

Remove RN patch

977f1cd

Remove Igor from notifications

9e42930

pedropombeiro force-pushed the fix/consistent-golang-version branch from 9d4e34e to 9e42930 Compare July 5, 2019 11:43

yenda approved these changes Jul 5, 2019

View reviewed changes

flexsurfer approved these changes Jul 5, 2019

View reviewed changes

asemiankevich added the Tested - OK label Jul 5, 2019

Fix RN 0.59.9 reference for mobile so it is deterministic

cef9f10

Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>

pedropombeiro force-pushed the fix/consistent-golang-version branch from 7c1f32f to cef9f10 Compare July 5, 2019 12:43

pedropombeiro merged commit cef9f10 into develop Jul 5, 2019

delete-merged-branch Bot deleted the fix/consistent-golang-version branch July 5, 2019 12:43

StatusWrike unassigned pedropombeiro Jan 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use go expression consistently#8529

Use go expression consistently#8529
pedropombeiro merged 6 commits into
developfrom
fix/consistent-golang-version

pedropombeiro commented Jul 4, 2019 •

edited by StatusWrike

Loading

Uh oh!

ghost commented Jul 4, 2019 •

edited by pedropombeiro

Loading

Uh oh!

status-im-auto commented Jul 4, 2019 •

edited

Loading

Uh oh!

ghost commented Jul 5, 2019

Uh oh!

statustestbot commented Jul 5, 2019

Uh oh!

ghost commented Jul 5, 2019

Uh oh!

ghost commented Jan 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

pedropombeiro commented Jul 4, 2019 • edited by StatusWrike Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review notes

Testing notes

Uh oh!

ghost commented Jul 4, 2019 • edited by pedropombeiro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Uh oh!

status-im-auto commented Jul 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

ghost commented Jul 5, 2019

Uh oh!

statustestbot commented Jul 5, 2019

100% of end-end tests have passed

Passed tests (44)

Uh oh!

ghost commented Jul 5, 2019

Uh oh!

ghost commented Jan 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pedropombeiro commented Jul 4, 2019 •

edited by StatusWrike

Loading

ghost commented Jul 4, 2019 •

edited by pedropombeiro

Loading

status-im-auto commented Jul 4, 2019 •

edited

Loading