Fix JavaScript lint errors

[stdlib-bot]

JavaScript Linting Failures

Linting failures were detected in the automated JavaScript lint workflow run.

Workflow Details

• Run: https://github.com/stdlib-js/stdlib/actions/runs/19053168200
• Type: JavaScript Linting
• Date: 2025-11-04 00:12:10 UTC

Error Details

make[1]: Entering directory '/home/runner/work/stdlib/stdlib'

Linting file: lib/node_modules/@stdlib/assert/is-circular-array/examples/index.js

Linting file: lib/node_modules/@stdlib/_tools/pkgs/toposort/examples/index.js

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: unexpected error. Failed to sort packages. Detected the following dependency chain containing a cycle: `@stdlib/ndarray/dtype-ctor -> @stdlib/ndarray/base/bytes-per-element -> @stdlib/ndarray/dtypes -> @stdlib/ndarray/base/dtype-objects -> @stdlib/ndarray/dtype-ctor -> @stdlib/ndarray/base/assert/is-data-type-string -> @stdlib/array/base/assert/contains -> @stdlib/array/base/accessor-getter`.
  at sort (/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/pkgs/toposort/lib/sort.js:111:9)
  at onPkgs (/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/pkgs/toposort/lib/async.js:92:11)
  at onGlob (/home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/pkgs/names/lib/async.js:98:3)
  at f (/home/runner/work/stdlib/stdlib/node_modules/once/once.js:25:25)
  at Glob.<anonymous> (/home/runner/work/stdlib/stdlib/node_modules/glob/glob.js:148:7)
  at Glob.emit (node:events:524:28)
  at Glob._finish (/home/runner/work/stdlib/stdlib/node_modules/glob/glob.js:194:8)
  at next (/home/runner/work/stdlib/stdlib/node_modules/glob/glob.js:213:12)
  at /home/runner/work/stdlib/stdlib/node_modules/glob/glob.js:245:9
  at /home/runner/work/stdlib/stdlib/node_modules/fs.realpath/index.js:37:7
Linting failed.

Linting file: lib/node_modules/@stdlib/array/base/cuevery-by-right/examples/index.js

Linting file: lib/node_modules/@stdlib/blas/ext/base/sdsnansum/examples/index.js

Linting file: lib/node_modules/@stdlib/assert/is-domain-name/examples/index.js
make[1]: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/eslint.mk:261: eslint-files] Error 1
make[1]: Leaving directory '/home/runner/work/stdlib/stdlib'
make: *** [/home/runner/work/stdlib/stdlib/tools/make/lib/lint/javascript/Makefile:158: lint-javascript-files] Error 2

Pull Request Instructions

• Please use the following PR title format:
  "chore: fix JavaScript lint errors (issue #<ISSUE_NUMBER>)".
• Reference this issue in the "Related Issues" section of the PR body as "resolves #<ISSUE_NUMBER>".

[stdlib-bot]

👋 Important: PLEASE READ 👋

This issue has been labeled as a good first issue and is available for anyone to work on.

If this is your first time contributing to an open source project, some aspects of the development process may seem unusual, arcane, or some combination of both.

1. You cannot "claim" issues. People new to open source often want to "claim" or be assigned an issue before beginning work. The typical rationale is that people want to avoid wasted work in the event that someone else ends up working the issue. However, this practice is not effective in open source, as it often leads to "issue squatting", in which an individual asks to be assigned, is granted their request, and then never ends up working on the issue. Accordingly, you are encouraged to communicate your intent to address this issue, ideally by providing a rough outline as to how you plan to address the issue or asking clarifying questions, but, at the end of the day, we will take running code and rough consensus in order to move forward quickly.
2. We have a very high bar for contributions. We have very high standards for contributions and expect all contributions—whether new features, tests, or documentation—to be rigorous, thorough, and complete. Once a pull request is merged into stdlib, that contribution immediately becomes the collective responsibility of all maintainers of stdlib. When we merge code into stdlib, we are saying that we, the maintainers, commit to reviewing subsequent changes and making bugfixes to the code. Hence, in order to ensure future maintainability, this naturally leads to a higher standard of contribution.

Before working on this issue and opening a pull request, please read the project's contributing guidelines. These guidelines and the associated development guide provide important information, including links to stdlib's Code of Conduct, license policy, and steps for setting up your local development environment.

To reiterate, we strongly encourage you to refer to our contributing guides before beginning work on this issue. Failure to follow our guidelines significantly decreases the likelihood that you'll successfully contribute to stdlib and may result in automatic closure of a pull request without review.

Setting up your local development environment is a critical first step, as doing so ensures that automated development processes for linting, license verification, and unit testing can run prior to authoring commits and pushing changes. If you would prefer to avoid manual setup, we provide pre-configured development containers for use locally or in GitHub Codespaces.

We place a high value on consistency throughout the stdlib codebase. We encourage you to closely examine other packages in stdlib and attempt to emulate the practices and conventions found therein.

• If you are attempting to contribute a new package, sometimes the best approach is to simply copy the contents of an existing package and then modify the minimum amount necessary to implement the feature (e.g., changing descriptions, parameter names, and implementation).
• If you are contributing tests, find a package implementing a similar feature and emulate the tests of that package.
• If you are updating documentation, examine several similar packages and emulate the content, style, and prose of those packages.

In short, the more effort you put in to ensure that your contribution looks and feels like stdlib—including variables names, bracket spacing, line breaks, etc—the more likely that your contribution will be reviewed and ultimately accepted. We encourage you to closely study the codebase before beginning work on this issue.

✨ Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. ✨

[SHASHI9705]

chore: fix JavaScript lint errors (issue #8380 )

During the linting process, an error occurs due to a circular dependency chain within the @stdlib/ndarray dtype-related modules. This cycle prevents successful package sorting during the make lint step.
Error: unexpected error. Failed to sort packages.
Detected the following dependency chain containing a cycle:
@stdlib/ndarray/dtype-ctor
→ @stdlib/ndarray/base/bytes-per-element
→ @stdlib/ndarray/dtypes
→ @stdlib/ndarray/base/dtype-objects
→ @stdlib/ndarray/dtype-ctor

Root Cause:

• A circular dependency exists among the dtype utility modules due to cross-imports. Specifically:

• dtype-ctor depends on bytes-per-element

• bytes-per-element depends on dtypes

• dtypes depends on dtype-objects

• dtype-objects again depends on dtype-ctor

Proposed Fix:

1. Identify and isolate the dependency that introduces the loop (likely within dtype-objects or bytes-per-element).

2. Refactor one dependency to use lazy loading (deferred require) or an intermediate constants module to break the cycle.

Conceptual fix:
// Instead of direct circular import:
const bytesPerElement = require('@stdlib/ndarray/base/bytes-per-element');

// Proposed lazy approach:
let bytesPerElement;
function getBytesPerElement() {
if (!bytesPerElement) {
bytesPerElement = require('@stdlib/ndarray/base/bytes-per-element');
}
return bytesPerElement;
}

3. Re-run lint and build tests to confirm that:

   The circular dependency is resolved.

   No functional regressions occur in ndarray dtype utilities.

4. Add regression test ensuring that circular imports are no longer detected for this package group.

Expected Outcome:

1: Successful linting and build without dependency cycle errors.

2: Cleaner module dependency graph within the ndarray dtype utilities.

3: Maintained backward compatibility with existing dtype-related functions.

Kindly assign this issue to me.
I’ve already reproduced the problem locally and verified the cyclic chain.
Once assigned, I’ll open a PR implementing the proposed fix with full testing.

[kgryte]

Did a bit of R&D, and the actual core issue is more nuanced in that there isn't an actual circular dependency. The issue is that the C implementation of bytes-per-element depends on dtypes in the manifest.json. However, dtype-ctor does not have a C implementation, so we are not at risk of any C circular deps. And the JS implementation of bytes-per-element does not depend on dtype-ctor. So there isn't actually a circular dep; this is a limitation of our dependency resolution tracking (e.g., see https://github.com/stdlib-js/stdlib/blob/cad68452e8d2a52ebe1ebfd74117d98197a4a568/lib/node_modules/%40stdlib/_tools/pkgs/dep-list/lib/deps.js#L87C2-L106C3), where we assume that C and JavaScript dependency trees are the same.

So, in short, I don't know any easy workaround for this at the moment.