feat: add C implementation for stats/base/ndarray/sminabs
#10044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a native C implementation for @stdlib/stats/base/ndarray/sminabs. This includes: - C implementation (src/main.c, src/addon.c) - Header file (include/stdlib/stats/base/ndarray/sminabs.h) - Build configurations (manifest.json, binding.gyp, include.gypi) - Native JavaScript binding (lib/native.js) - Native benchmarks (benchmark.native.js, benchmark/c/*) - Native tests (test.native.js) - C examples (examples/c/*) - Updated README with C APIs section - Updated package.json with native addon configuration PR-URL: https://github.com/stdlib-js/stdlib/pull/XXXX Closes: https://github.com/stdlib-js/stdlib/issues/YYYY --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
Updated function documentation to clarify that it computes the minimum absolute value instead of just the minimum value. Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
Add 'absolute' and 'abs' keywords to package.json Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
Updated copyright year from 2026 to 2025 and modified example input values in README. Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>
Sachinn-64
approved these changes
Feb 5, 2026
Member
There was a problem hiding this comment.
@Erennn7 We should be only working on the C implementation part, the keywords, examples should be kept similar as before.
Contributor
Author
|
@Sachinn-64 got it, did the changes in the rest of the pr's as welll. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #{{TODO: add issue number}}.
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers