feat: add C implementation for `stats/base/ndarray/dnanmidrange` by bhargava-d16 · Pull Request #10203 · stdlib-js/stdlib

bhargava-d16 · 2026-02-10T17:07:14Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: na
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: na
task: lint_license_headers status: passed ---

Resolves None

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for stats/base/ndarray/dnanmidrange

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

#{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-02-10T17:10:08Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/ndarray/dnanmidrange	$\color{green}170/170$ $\color{green}+0.00%$	$\color{green}7/7$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}170/170$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

bhargava-d16 · 2026-03-09T07:02:30Z

@Planeshifter Just a gentle follow-up on this PR.

Planeshifter · 2026-02-13T02:49:20Z

+#include "stdlib/stats/base/ndarray/dnanmidrange.h"
+```
+
+stdlib_stats_dnanmidrange( arrays )


This needs to be formatted as a #### heading to match our convention for C function signatures. See, e.g., the dmax README for reference.

Suggested change

stdlib_stats_dnanmidrange( arrays )

#### stdlib_stats_dnanmidrange( arrays )

Planeshifter · 2026-02-13T02:49:27Z

+#include <stdint.h>
+
+// Create an ndarray:
+const double data[] = { 1.0, NaN, -2.0, 3.0, -4.0 };


NaN isn't valid C -- the correct macro is NAN (from <math.h>). You'll also need to add #include <math.h> to this code block (similar to how you did it in the actual .c files).

Suggested change

const double data[] = { 1.0, NaN, -2.0, 3.0, -4.0 };

const double data[] = { 1.0, NAN, -2.0, 3.0, -4.0 };

Instead of using NAN, we should prefer the expression 0.0/0.0 and remove the math.h include, as Athan mentioned here: 5a64342#r179146895

Planeshifter · 2026-02-13T02:49:32Z

+
+int main( void ) {
+    // Create a data buffer (includes NaN):
+    const double data[] = { 1.0, -2.0, 3.0, NaN, 5.0, -6.0, 7.0, -8.0 };


Same thing here -- NaN should be NAN.

Suggested change

const double data[] = { 1.0, -2.0, 3.0, NaN, 5.0, -6.0, 7.0, -8.0 };

const double data[] = { 1.0, -2.0, 3.0, NAN, 5.0, -6.0, 7.0, -8.0 };

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 · 2026-03-10T09:06:50Z

+var opts = {
+	'skip': ( dnanmidrange instanceof Error )
+};


Suggested change

var opts = {

'skip': ( dnanmidrange instanceof Error )

};

var opts = {

'skip': ( dnanmidrange instanceof Error )

};

var options = {

'dtype': 'float64'

};

Sachinn-64 · 2026-03-10T09:07:57Z

+	var x;
+
+	xbuf = filledarrayBy( len, 'float64', rand );
+	x = new ndarray( 'float64', xbuf, [ len ], [ 1 ], 0, 'row-major' );


Suggested change

x = new ndarray( 'float64', xbuf, [ len ], [ 1 ], 0, 'row-major' );

x = new ndarray( options.dtype, xbuf, [ len ], [ 1 ], 0, 'row-major' );

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 · 2026-03-11T09:19:49Z

+
+int main( void ) {
+	// Create a data buffer:
+	const double data[] = { 1.0, -2.0, 3.0, -4.0, NAN, 5.0, 0.0, 3.0 };


Suggested change

const double data[] = { 1.0, -2.0, 3.0, -4.0, NAN, 5.0, 0.0, 3.0 };

const double data[] = { 1.0, -2.0, 3.0, -4.0, 0.0/0.0, 5.0, 0.0, 3.0 };

We could do this.

Sachinn-64 · 2026-03-11T09:20:00Z

+#include <stdint.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <math.h>


Suggested change

#include <math.h>

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 · 2026-03-11T09:33:17Z

+
+stdlib_stats_dnanmidrange( arrays )
+
+Computes the mid-range of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.


Suggested change

Computes the mid-range of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.

Computes the [mid-range][mid-range] of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.

Sachinn-64 · 2026-03-11T09:33:50Z

+#include <stdio.h>
+
+int main( void ) {
+    // Create a data buffer (includes NaN):


Suggested change

// Create a data buffer (includes NaN):

// Create a data buffer:

Sachinn-64 · 2026-03-11T09:34:32Z

+    const int64_t nsubmodes = 1;
+
+    // Create an ndarray:
+    struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT64, (uint8_t *)data, ndims, shape, strides, offset, order, imode,  nsubmodes, submodes );


Suggested change

struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT64, (uint8_t *)data, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

struct ndarray *x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT64, (uint8_t *)data, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

Sachinn-64 · 2026-03-11T09:35:10Z

+    // Define a list of ndarrays:
+    const struct ndarray *arrays[] = { x };
+
+    // Compute the NaN-ignoring midrange:


Suggested change

// Compute the NaN-ignoring midrange:

// Compute the mid-range:

Sachinn-64 · 2026-03-11T09:35:29Z

+    double v = stdlib_stats_dnanmidrange( arrays );
+
+    // Print the result:
+    printf( "midrange: %lf\n", v );


Suggested change

printf( "midrange: %lf\n", v );

printf( "mid-range: %lf\n", v );

kgryte · 2026-04-21T02:53:37Z

/stdlib merge

…midrange

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 10, 2026

bhargava-d16 added 2 commits February 10, 2026 17:15

Sachinn-64 self-requested a review February 12, 2026 06:57

Planeshifter requested changes Mar 9, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 9, 2026

Sachinn-64 added 2 commits March 10, 2026 13:55

Update benchmark.length.c

cfb890d

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Update benchmark.native.js

b510fdc

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 reviewed Mar 10, 2026

View reviewed changes

Update example.c

b1a3c12

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 reviewed Mar 11, 2026

View reviewed changes

Sachinn-64 added 5 commits March 11, 2026 14:51

Update dnanmidrange.h

d22d023

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Update native.js

4cba23e

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Update main.c

e4faa66

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Update test.main.js

c3b1ebb

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Update test.native.js

0cd3b87

Signed-off-by: Sachin Pangal <151670745+Sachinn-64@users.noreply.github.com>

Sachinn-64 reviewed Mar 11, 2026

View reviewed changes

kgryte added the Feature Issue or pull request for adding a new feature. label Apr 21, 2026

kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3 labels Apr 21, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 21, 2026

Merge remote-tracking branch 'upstream/develop' into feat-ndarray-nan…

1d43e48

…midrange

stdlib-bot requested a review from a team April 21, 2026 03:36

stdlib-bot added Needs Review A pull request which needs code review. and removed bot: In Progress Pull request is currently awaiting automation. labels Apr 21, 2026

	stdlib_stats_dnanmidrange( arrays )
	#### stdlib_stats_dnanmidrange( arrays )

	const double data[] = { 1.0, NaN, -2.0, 3.0, -4.0 };
	const double data[] = { 1.0, NAN, -2.0, 3.0, -4.0 };

	const double data[] = { 1.0, -2.0, 3.0, NaN, 5.0, -6.0, 7.0, -8.0 };
	const double data[] = { 1.0, -2.0, 3.0, NAN, 5.0, -6.0, 7.0, -8.0 };

	x = new ndarray( 'float64', xbuf, [ len ], [ 1 ], 0, 'row-major' );
	x = new ndarray( options.dtype, xbuf, [ len ], [ 1 ], 0, 'row-major' );


		stdlib_stats_dnanmidrange( arrays )

		Computes the mid-range of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.

	Computes the mid-range of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.
	Computes the [mid-range][mid-range] of a one-dimensional double-precision floating-point ndarray, ignoring NaN values.

	// Create a data buffer (includes NaN):
	// Create a data buffer:

	struct ndarray x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT64, (uint8_t )data, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );
	struct ndarray x = stdlib_ndarray_allocate( STDLIB_NDARRAY_FLOAT64, (uint8_t )data, ndims, shape, strides, offset, order, imode, nsubmodes, submodes );

	// Compute the NaN-ignoring midrange:
	// Compute the mid-range:

	printf( "midrange: %lf\n", v );
	printf( "mid-range: %lf\n", v );

Uh oh!

Conversation

bhargava-d16 commented Feb 10, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

bhargava-d16 commented Mar 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sachinn-64 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stdlib-bot commented Feb 10, 2026 •

edited

Loading

Sachinn-64 Mar 10, 2026 •

edited

Loading