feat: add math/base/special/cexpf#10223
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: missing_dependencies
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue". Why this matters: Required action: Thank you for your contribution to the project! |
| */ | ||
|
|
||
| #include "stdlib/math/base/special/cexpf.h" | ||
| #include "stdlib/math/base/special/exp.h" |
There was a problem hiding this comment.
@nirmaljb We will require the single-precision implementation of exp here (which we currently don't have) , right?
There was a problem hiding this comment.
Yes! You can block this PR for the time being.
| var sincosf = require( '@stdlib/math/base/special/sincosf' ); | ||
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||
| var isInfinitef = require( '@stdlib/math/base/assert/is-infinitef' ); | ||
| var exp = require( '@stdlib/math/base/special/exp' ); |
There was a problem hiding this comment.
The pr needs to blocked untill expf gets merged.
|
|
||
| --> | ||
|
|
||
| # expf |
There was a problem hiding this comment.
| # expf | |
| # cexpf |
| * @param {Complex64} z - complex number | ||
| * @returns {Complex64} result |
There was a problem hiding this comment.
Missing @private tag. See cexp/lib/native.js.
| * @param {Complex64} z - complex number | |
| * @returns {Complex64} result | |
| * @private | |
| * @param {Complex64} z - complex number | |
| * @returns {Complex64} result |
|
|
||
| // MAIN // | ||
|
|
||
| bench( format( '%s', pkg ), function benchmark( b ) { |
There was a problem hiding this comment.
pkg is already a string; wrapping it in format( '%s', pkg ) is a no-op. Pass it directly and drop the format import on line 25.
| bench( format( '%s', pkg ), function benchmark( b ) { | |
| bench( pkg, function benchmark( b ) { |
| <!-- <div class="equation" align="center" data-raw-text="\operatorname{exp}(z) = e^{x + i y} = (\exp{x}) (\cos(y) + i \sin(y))" data-equation="eq:cexp_function"> | ||
| <img src="https://cdn.jsdelivr.net/gh/stdlib-js/stdlib@d4edb68b52a6c646be5683023c5a24890300727f/lib/node_modules/@stdlib/math/base/special/cexp/docs/img/equation_cexp_function.svg" alt="Complex exponential function"> | ||
| <br> | ||
| </div> --> | ||
|
|
There was a problem hiding this comment.
Will be auto-generated.
| <!-- <div class="equation" align="center" data-raw-text="\operatorname{exp}(z) = e^{x + i y} = (\exp{x}) (\cos(y) + i \sin(y))" data-equation="eq:cexp_function"> | |
| <img src="https://cdn.jsdelivr.net/gh/stdlib-js/stdlib@d4edb68b52a6c646be5683023c5a24890300727f/lib/node_modules/@stdlib/math/base/special/cexp/docs/img/equation_cexp_function.svg" alt="Complex exponential function"> | |
| <br> | |
| </div> --> |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses: #649
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted Claude Opus 4.6 (Thinking) to find reference packages, but the proposed changes were fully authored manually by myself.
@stdlib-js/reviewers