fix: replace new Array() with array literals in test files#10257
Open
infinityanant wants to merge 1 commit intostdlib-js:developfrom
Open
fix: replace new Array() with array literals in test files#10257infinityanant wants to merge 1 commit intostdlib-js:developfrom
infinityanant wants to merge 1 commit intostdlib-js:developfrom
Conversation
- Replace new Array() constructor with array literal pattern in ahavercos-by tests
- Replace new Array() with explicit array in is-empty-collection test
- Resolves linting errors (stdlib/no-new-array rule violations)
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
new Array()constructor with array literal pattern in ahavercos-by testsnew Array()with explicit array in is-empty-collection testRelated Issues
This pull request:
Questions
No.
Other
Changes Made:
File 1:
lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.main.jsx = new Array( 5 );tox = []; x.length = 5; // sparse arrayFile 2:
lib/node_modules/@stdlib/math/strided/special/ahavercos-by/test/test.ndarray.jsx = new Array( 5 );tox = []; x.length = 5; // sparse arrayFile 3:
lib/node_modules/@stdlib/assert/is-empty-collection/test/test.jsnew Array( 10 ),to[ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ],All linting tests now pass locally.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
[ ] Code generation
[ ] Test/benchmark generation
[ ] Documentation (including examples)
[ ] Research and understanding
@stdlib-js/reviewers
Fixes: #10184