Skip to content

chore: update tests and use string interpolation in math/base/special/sqrt1pm1#10324

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
shubham220420:shubham2204-sqrt1pm1
Feb 17, 2026
Merged

chore: update tests and use string interpolation in math/base/special/sqrt1pm1#10324
Planeshifter merged 1 commit intostdlib-js:developfrom
shubham220420:shubham2204-sqrt1pm1

Conversation

@shubham220420
Copy link
Contributor


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves none

Description

What is the purpose of this pull request?

This pull request:

  • Updates the unassigned values to v in test files in math/base/special/sqrt1pm1
  • Refactor to use string interpolation in math/base/special/sqrt1pm1

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None related but discussed in PR

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

…qrt1pm1

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 16, 2026
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sqrt1pm1 $\color{green}203/203$
$\color{green}+100.00%$
$\color{green}9/9$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}203/203$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The test bug catch is good -- the previous code was asserting against a stale value of v instead of the fresh return value. The format refactor in the native benchmark also looks correct and matches the current convention.

I am going to merge this via a "chore:" commit.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 17, 2026
@Planeshifter Planeshifter changed the title fix: update tests and use string interpolation in math/base/special/sqrt1pm1 chore: update tests and use string interpolation in math/base/special/sqrt1pm1 Feb 17, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 17, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: update tests and use string interpolation in `math/base/special/sqrt1pm1`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10324

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 1ac0545 into stdlib-js:develop Feb 17, 2026
72 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 17, 2026
@shubham220420 shubham220420 deleted the shubham2204-sqrt1pm1 branch February 17, 2026 07:54
DivitJain26 pushed a commit to DivitJain26/stdlib-divit that referenced this pull request Feb 25, 2026
…l/sqrt1pm1`

PR-URL: stdlib-js#10324

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants