chore: update tests and use string interpolation in math/base/special/sqrt1pm1#10324
Merged
Planeshifter merged 1 commit intostdlib-js:developfrom Feb 17, 2026
Merged
Conversation
…qrt1pm1
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
requested changes
Feb 17, 2026
Member
There was a problem hiding this comment.
Thanks for the fix! The test bug catch is good -- the previous code was asserting against a stale value of v instead of the fresh return value. The format refactor in the native benchmark also looks correct and matches the current convention.
I am going to merge this via a "chore:" commit.
Planeshifter
approved these changes
Feb 17, 2026
math/base/special/sqrt1pm1math/base/special/sqrt1pm1
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
DivitJain26
pushed a commit
to DivitJain26/stdlib-divit
that referenced
this pull request
Feb 25, 2026
…l/sqrt1pm1` PR-URL: stdlib-js#10324 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves none
Description
This pull request:
vin test files inmath/base/special/sqrt1pm1math/base/special/sqrt1pm1Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers