feat: add C implementation for stats/base/ndarray/smeanpw#10389
feat: add C implementation for stats/base/ndarray/smeanpw#10389AtharvaPatange wants to merge 5 commits intostdlib-js:developfrom
stats/base/ndarray/smeanpw#10389Conversation
stdlib-bot
added
the
Statistics
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
stdlib-bot
added
First-time Contributor
AtharvaPatange
changed the title
stats/base/ndarray/smeanstats/base/ndarray/smeanpw
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * @license Apache-2.0 | |||
| * | |||
| * Copyright (c) 2026 The Stdlib Authors. | |||
| * Copyright (c) 2025 The Stdlib Authors. | |||
There was a problem hiding this comment.
Copyright year for newly created files should be 2026. Same should apply to src/Makefile, test/test.main.js, and test/test.native.js. However it should be kept to 2025 in README.md
| ], # end actions | ||
| }, # end target copy_addon | ||
| ], # end targets | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file is missing a trailing newline. The project's .editorconfig requires insert_final_newline = true for all files.
| '<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).libpath; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")', | ||
| ], | ||
| }, # end variables | ||
| } No newline at end of file |
There was a problem hiding this comment.
Same as binding.gyp - this file is missing a trailing newline. The .editorconfig requires insert_final_newline = true.
| #/ | ||
| # @license Apache-2.0 | ||
| # | ||
| # Copyright (c) 2025 The Stdlib Authors. |
There was a problem hiding this comment.
Same here - newly created file should use 2026 as the copyright year.
| # Copyright (c) 2025 The Stdlib Authors. | |
| # Copyright (c) 2026 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. |
There was a problem hiding this comment.
This is a new file, so the copyright year should be 2026.
| * Copyright (c) 2025 The Stdlib Authors. | |
| * Copyright (c) 2026 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. |
There was a problem hiding this comment.
This is a new file, so the copyright year should be 2026.
| * Copyright (c) 2025 The Stdlib Authors. | |
| * Copyright (c) 2026 The Stdlib Authors. |
| @license Apache-2.0 | ||
|
|
||
| Copyright (c) 2025 The Stdlib Authors. | ||
| Copyright (c) 2026 The Stdlib Authors. |
There was a problem hiding this comment.
The copyright year for this existing file was changed from 2025 to 2026. Existing files should retain their original copyright year. Please revert this change.
| Copyright (c) 2026 The Stdlib Authors. | |
| Copyright (c) 2025 The Stdlib Authors. |
Planeshifter
added
Needs Changes
4 participants
Resolves none
Description
This pull request:
stats/base/ndarray/smeanpwRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers