chore: address commit comments for commit 8b01d81 (issue #10423)#10432
chore: address commit comments for commit 8b01d81 (issue #10423)#10432parthodas23 wants to merge 1 commit intostdlib-js:developfrom
Conversation
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
1 similar comment
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Description
This pull request:
tabulate-byexamples to use@stdlib/random/array/discrete-uniformand@stdlib/array/takefor a more idiomatic approach.README.mdto ensure documentation matches the new implementation.Related Issues
This pull request has the following related issues:
8b01d81) #10423Questions
None.
Other
Verified changes by running:
make EXAMPLES_FILTER=".*/utils/tabulate-by/.*" examplesChecklist
AI Assistance
Disclosure
@stdlib-js/reviewers